GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(sampling): Respect incoming sample rate if not explicitly overridden by sentrivana · Pull Request #8185 · getsentry/sentry-python

Conversation

@sentrivana

@sentrivana sentrivana commented Nov 4, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Description

If there's an incoming sampling decision, traces_sample_rate is irrelevant and shouldn't overwrite the sampling rate in the DSC.

There are cases where we do want to override the incoming sampling decision, but only in cases where the SDK actually uses a different sample rate for some reason (traces_sampler).

Issues

Closes #8182

Reminders

  • Please add tests to validate your changes, and lint your code using uv run ruff.
  • Add GH Issue ID & Linear ID (if applicable)
  • PR title should use conventional commit style (feat:, fix:, ref:, meta:)
  • For external contributors: CONTRIBUTING.md, Sentry SDK development docs, Discord community

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions

github-actions Bot commented Nov 4, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 137214 passed | ⏭️ 7456 skipped | Total: 144670 | Pass Rate: 94.85% | Execution Time: 442m 23s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ Test counts unchanged from base.

All tests are passing successfully.

✅ Patch coverage is 100.00% (4 of 4 changed executable lines covered; target 80%).
Project statement coverage is 90.32% (down 0.01 percentage points from base (dbc50bd) to head (8a5a066)).

Changed files with executable lines (1)
File Patch coverage Changed executable lines
sentry_sdk/scope.py 100.00% 4/4 covered
Coverage diff 
@@            Coverage Diff             @@
##        master     #8185       +/-##
==========================================
- Coverage    90.33%    90.32%    -0.01%
==========================================
  Files          203       203         —
  Tracked lines     26905     26907        +2
  Branches     10048     10048         —
==========================================
  Hits         24302     24302         —
- Misses        2603      2605        +2
- Partials      1516      1518        +2

Generated by Coverage Action
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sentry-warden[bot]
sentry-warden Bot reviewed Nov 4, 2026
View reviewed changes
Comment thread sentry_sdk/scope.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sentrivana
fix(sampling): Respect incoming sample_rate if not explicitly overridden
8a5a066
@sentrivana
sentrivana force-pushed the ivana/preserve-incoming-sample-rate branch from 3a43948 to 8a5a066 Compare November 5, 2026 09:04
sentry-warden[bot]
sentry-warden Bot reviewed Nov 5, 2026
View reviewed changes
Comment thread sentry_sdk/scope.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sentrivana
sentrivana marked this pull request as ready for review November 5, 2026 09:19
@sentrivana
sentrivana requested a review from a team as a code owner November 5, 2026 09:19
alexander-alderman-webb
alexander-alderman-webb approved these changes Nov 5, 2026
View reviewed changes
@sentrivana
sentrivana enabled auto-merge (squash) November 5, 2026 09:22
@sentrivana
sentrivana merged commit b787a9a into master Nov 5, 2026
324 of 327 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@sentrivana
sentrivana deleted the ivana/preserve-incoming-sample-rate branch November 5, 2026 09:28
This was referenced Nov 5, 2026
publish: getsentry/[email protected] getsentry/publish#10240
Closed
publish: getsentry/[email protected] getsentry/publish#10305
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentry-warden sentry-warden[bot] sentry-warden[bot] left review comments
@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Continued traces propagate sample_rate=1.0 instead of upstream

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sentrivana @alexander-alderman-webb
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.