GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(bedrock): Add extension skeleton by alexander-alderman-webb · Pull Request #8226 · getsentry/sentry-python

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Nov 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Add a basic bedrock extension that creates chat spans with the gen_ai.operation.name, gen_ai.provider.name and gen_ai.response.streaming attributes.

This is the first boto3 extension. I've cleaned up some things:

  • Remove registry.py. We control all extensions in the SDK, so this indirection seems unnecessary.
  • Related to the above, remove tests for the registry system that define mock extensions. Create success and error test cases in test_bedrock.py so the relevant behavior is still exercised.
  • Remove capture_internal_exceptions() around invocations of extension functions. If there's code that can raise in the extensions, the extensions can wrap the relevant lines themselves.
  • Add a skip_if_no_active_span boolean so that Bedrock spans are created even when there is no active span, matching the behavior of other chat integrations.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/bedrock/skeleton branch 4 times, most recently from 819486b to 3fc87ab Compare November 9, 2026 09:37
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review November 9, 2026 09:41
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner November 9, 2026 09:41
sentry-warden[bot]
sentry-warden Bot reviewed Nov 9, 2026
View reviewed changes
Comment thread sentry_sdk/integrations/boto3/_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread tests/integrations/boto3/test_bedrock.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

cursor[bot]
cursor Bot reviewed Nov 9, 2026
View reviewed changes

@cursor cursor Bot left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread sentry_sdk/integrations/boto3/_services/bedrock.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@github-actions

github-actions Bot commented Nov 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 137283 passed | ⏭️ 7575 skipped | Total: 144858 | Pass Rate: 94.77% | Execution Time: 447m 51s

All tests are passing successfully.

✅ Patch coverage is 91.18% (31 of 34 changed executable lines covered; target 80%).
Project statement coverage is 90.29% (down 0.06 percentage points from base (d565fed) to head (f532a4f)).

Changed files with executable lines (4)
File Patch coverage Changed executable lines
sentry_sdk/integrations/boto3/_services/bedrock.py 85.00% 17/20 covered; missed: 19, 24, 29; partial branches: 18, 23, 28
sentry_sdk/integrations/boto3/_instrumentation.py 100.00% 9/9 covered; partial branches: 185, 189, 195
sentry_sdk/integrations/boto3/_client.py 100.00% 4/4 covered
sentry_sdk/integrations/boto3/_services/base.py 100.00% 1/1 covered
Coverage diff
@@            Coverage Diff             @@
##        master     #8226       +/-##
==========================================
- Coverage    90.35%    90.29%    -0.06%
==========================================
  Files          203       203         —
  Tracked lines     26931     26953       +22
  Branches     10058     10066        +8
==========================================
+ Hits         24331     24335        +4
- Misses        2600      2618       +18
- Partials      1517      1523        +6

Generated by Coverage Action

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/bedrock/skeleton branch from 3fc87ab to d6cde74 Compare November 9, 2026 09:51
cursor[bot]
cursor Bot reviewed Nov 9, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d6cde74. Configure here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread tests/integrations/boto3/test_bedrock.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as draft November 9, 2026 09:54
@alexander-alderman-webb
feat(bedrock): Add extension skeleton
0099e3e
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/bedrock/skeleton branch from d6cde74 to 0099e3e Compare November 9, 2026 10:04
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review November 9, 2026 10:04
sentrivana
sentrivana approved these changes Nov 9, 2026
View reviewed changes

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@alexander-alderman-webb
fix boolean logic
f532a4f
@alexander-alderman-webb
alexander-alderman-webb merged commit da37f0a into master Nov 9, 2026
171 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@alexander-alderman-webb
alexander-alderman-webb deleted the webb/bedrock/skeleton branch November 9, 2026 14:02
@sentry-release-bot sentry-release-bot Bot mentioned this pull request Nov 12, 2026
publish: getsentry/[email protected] getsentry/publish#10388
Closed
6 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments
@sentry-warden sentry-warden[bot] sentry-warden[bot] left review comments
@sentrivana sentrivana sentrivana approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@alexander-alderman-webb @sentrivana
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.