GeezerVison is showing github.com — feat(bedrock): Add extension skeleton by alexander-alderman-webb · Pull Request #8226 · getsentry/sentry-python
Conversation
Add a basic bedrock extension that creates chat spans with the gen_ai.operation.name, gen_ai.provider.name and gen_ai.response.streaming attributes.
This is the first boto3 extension. I've cleaned up some things:
- Remove
registry.py. We control all extensions in the SDK, so this indirection seems unnecessary.
- Related to the above, remove tests for the registry system that define mock extensions. Create success and error test cases in
test_bedrock.py so the relevant behavior is still exercised.
- Remove
capture_internal_exceptions() around invocations of extension functions. If there's code that can raise in the extensions, the extensions can wrap the relevant lines themselves.
- Add a
skip_if_no_active_span boolean so that Bedrock spans are created even when there is no active span, matching the behavior of other chat integrations.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
cursor
Bot
left a comment
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale Bugbot comment from a previous run.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Coverage Results 📊
✅ 137283 passed | ⏭️ 7575 skipped | Total: 144858 | Pass Rate: 94.77% | Execution Time: 447m 51s
All tests are passing successfully.
✅ Patch coverage is 91.18% (31 of 34 changed executable lines covered; target 80%).
Project statement coverage is 90.29% (down 0.06 percentage points from base (d565fed) to head (f532a4f)).
Changed files with executable lines (4)
Coverage diff
@@ Coverage Diff @@
## master #8226 +/-##
==========================================
- Coverage 90.35% 90.29% -0.06%
==========================================
Files 203 203 —
Tracked lines 26931 26953 +22
Branches 10058 10066 +8
==========================================
+ Hits 24331 24335 +4
- Misses 2600 2618 +18
- Partials 1517 1523 +6
Generated by Coverage Action
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d6cde74. Configure here.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|