GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat(bedrock): Set token attributes for non-streaming responses by alexander-alderman-webb · Pull Request #8234 · getsentry/sentry-python

Conversation

alexander-alderman-webb commented Nov 9, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

Set token attributes for the nonstreaming Converse API.
Add the mypy-boto3-bedrock-runtime type checking dependency.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          feat(bedrock): Set token attributes for nonstreaming responses

dd9644c

alexander-alderman-webb force-pushed the webb/bedrock/response-model branch from 40ba237 to dd9644c Compare

November 9, 2026 16:05

github-actions Bot commented Nov 9, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Coverage Results 📊

✅ 137444 passed | ⏭️ 7671 skipped | Total: 145115 | Pass Rate: 94.71% | Execution Time: 441m 35s

All tests are passing successfully.

✅ Patch coverage is 100.00% (16 of 16 changed executable lines covered; target 80%).
Project statement coverage is 90.29% (down 0.03 percentage points from base (effa11a) to head (832f743)).

Changed files with executable lines (1)

File	Patch coverage	Changed executable lines
sentry_sdk/integrations/boto3/_services/bedrock.py	100.00%	16/16 covered

Coverage diff

@@            Coverage Diff             @@
##        master     #8234       +/-##
==========================================
- Coverage    90.32%    90.29%    -0.03%
==========================================
  Files          203       203         —
  Tracked lines     27020     27034       +14
  Branches     10106     10112        +6
==========================================
+ Hits         24404     24408        +4
- Misses        2616      2626       +10
- Partials      1534      1537        +3

Generated by Coverage Action

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alexander-alderman-webb added this pull request to stack #8236

November 10, 2026 11:33

alexander-alderman-webb marked this pull request as ready for review

November 10, 2026 11:36

alexander-alderman-webb requested a review from a team as a code owner

November 10, 2026 11:36

cursor Bot reviewed

Nov 10, 2026

View reviewed changes

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

sentry_sdk/integrations/boto3/_services/bedrock.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

alexander-alderman-webb marked this pull request as draft

November 10, 2026 11:45

alexander-alderman-webb added 2 commits

November 10, 2026 12:53


          include cached tokens in input tokens

7c834a4


          merge

7b53fb3

alexander-alderman-webb marked this pull request as ready for review

November 10, 2026 11:57

cursor Bot reviewed

Nov 10, 2026

View reviewed changes

cursor Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 7b53fb3. Configure here.}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

sentry_sdk/integrations/boto3/_services/bedrock.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

sentrivana approved these changes

Nov 10, 2026

View reviewed changes

alexander-alderman-webb removed this pull request from stack #8236

November 10, 2026 15:15


          merge master

832f743

alexander-alderman-webb changed the title ~~feat(bedrock): Set token attributes for nonstreaming responses~~ feat(bedrock): Set token attributes for non-streaming responses

Nov 10, 2026

alexander-alderman-webb enabled auto-merge (squash)

November 10, 2026 15:23

alexander-alderman-webb merged commit f110be5 into master

Nov 10, 2026

169 checks passed

Uh oh!

There was an error while loading. Please reload this page.

alexander-alderman-webb deleted the webb/bedrock/response-model branch

November 10, 2026 15:31

sentry-release-bot Bot mentioned this pull request

Nov 12, 2026

publish: getsentry/[email protected] getsentry/publish#10388

Closed

6 tasks done

Reviewers

cursor[bot]

cursor[bot] left review comments

sentrivana

sentrivana approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

alexander-alderman-webb commented Nov 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Results 📊

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alexander-alderman-webb commented Nov 9, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot commented Nov 9, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.