GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore(warden): Add sdk-review skill and run built-in code-review by sentry-junior[bot] · Pull Request #8247 · getsentry/sentry-python

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Part of a pilot to see if Warden can replace Bugbot for backend SDK review. sdk-review (.agents/skills/sdk-review/SKILL.md) is a minimal, report-only skill for Sentry SDK contract violations (host-app safety, data-collection gates, supported versions, public API, plus a few language-specific rules taken from Bugbot findings people acted on). Generic logic bugs are left to Warden's built-in code-review. Nothing here fails checks. I ran Warden v0.53.0 locally and the skill loads from .agents/skills/sdk-review.

Aligns the repo with sentry-dotnet and sentry-go:

  • dotagents-managed skills are no longer committed. agents.lock and .agents/.gitignore are ignored, as dotagents recommends, and the legacy gitignore = false is gone. Warden prefers repo-local skills over its built-ins, so the committed .agents/skills/code-review (the getsentry/skills checklist) was shadowing Warden's built-in code-review. A local run now resolves code-review to the built-in.
  • skill-scanner loads from getsentry/skills remotely and only runs on agent skill and instruction files. Before, it reviewed every changed file (53–61 min on recent large PRs). The org config ignores **/*.md, so for now it can't read SKILL.md or AGENTS.md; fixing that needs a change to the org warden.toml.
  • code-review skips uv.lock and the generated test-integrations-*.yml workflows.
  • The repo security-review block is removed. The org base config always wins over it, so it never ran ("Using the base config skill and ignoring the repo config duplicate" in the Warden logs).

For reviewers: after merging, local agent skills come from dotagents install instead of the checkout.

Refs SDK-1580

via @dingsdax.

--

View Session [Sentry]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sentry-junior Bot and others added 4 commits November 11, 2026 12:11
@sentry-junior @dingsdax
chore(warden): Add sdk-review skill and run built-in code-review
9dea8b0 
Add a report-only sdk-review Warden skill for SDK contract violations. Stop committing dotagents-managed skills so Warden resolves code-review to its built-in, as in sentry-dotnet and sentry-go.

Co-Authored-By: Johannes Daxböck <[email protected]>
@sentry-junior @dingsdax
chore(warden): Scope skill-scanner to agent files and drop shadowed s…
07ecca6 
…ecurity-review

The org base config wins over a repo security-review entry, so the repo block never ran. skill-scanner was reviewing every changed file; it now only runs on agent skill and instruction files.

Co-Authored-By: Johannes Daxböck <[email protected]>
@sentry-junior @dingsdax
fix(warden): Quote sdk-review skill description
6261b20 
The unquoted colon made the YAML frontmatter invalid, so Warden could not load the skill.

Co-Authored-By: Johannes Daxböck <[email protected]>
@sentry-junior @dingsdax
chore(warden): State that no findings is the normal sdk-review result
e069024 
Co-Authored-By: Johannes Daxböck <[email protected]>
@sentry-junior sentry-junior Bot assigned dingsdax Nov 11, 2026
@linear-code

linear-code Bot commented Nov 11, 2026

Copy link
Copy Markdown

SDK-1580
sentry-junior[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sentry-junior Bot and others added 2 commits November 11, 2026 14:19
@sentry-junior @dingsdax
chore(warden): Skip draft PRs for code-review and sdk-review
d8e375d 
Matches sentry-dotnet. Large draft test PRs cost about $30 per push.

Co-Authored-By: Johannes Daxböck <[email protected]>
@sentry-junior @dingsdax
chore(warden): Point sdk-review at the declared version minimums
28db792 
Co-Authored-By: Johannes Daxböck <[email protected]>
@github-actions

github-actions Bot commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 139110 passed | ⏭️ 7765 skipped | Total: 146875 | Pass Rate: 94.71% | Execution Time: 436m 35s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ Test counts unchanged from base.

All tests are passing successfully.

✅ Patch coverage is 100.00% (no changed executable lines found; target 80%).
Project statement coverage is 90.21% (down 0.03 percentage points from base (f35474a) to head (4654528)).

Coverage diff 
@@            Coverage Diff             @@
##        master     #8247       +/-##
==========================================
- Coverage    90.24%    90.21%    -0.03%
==========================================
  Files          203       203         —
  Tracked lines     27125     27229      +104
  Branches     10142     10198       +56
==========================================
+ Hits         24478     24564       +86
- Misses        2647      2665       +18
- Partials      1541      1555       +14

Generated by Coverage Action
sentry-junior[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sentry-junior Bot and others added 3 commits November 11, 2026 14:40
@sentry-junior @dingsdax
chore(warden): Align sdk-review with Bugbot learned rules
f7dd283 
Name the data_collection gate instead of send_default_pii, and drop rules that contradict the team's Bugbot rules (Go Close/overflow, Python stream exceptions).

Co-Authored-By: Johannes Daxböck <[email protected]>
@sentry-junior @dingsdax
chore(warden): Align sdk-review data-collection rule with the spec
7c13db5 
Automatic collection goes through the denylist filter; user-set data is never gated (develop-docs data-collection spec).

Co-Authored-By: Johannes Daxböck <[email protected]>
@sentry-junior @dingsdax
chore(warden): Skip generated files in code-review
4654528 
Co-Authored-By: Johannes Daxböck <[email protected]>
@sentry-junior
sentry-junior Bot marked this pull request as ready for review November 11, 2026 15:02
@sentry-junior
sentry-junior Bot requested a review from a team as a code owner November 11, 2026 15:02
alexander-alderman-webb
alexander-alderman-webb approved these changes Nov 11, 2026
View reviewed changes
@dingsdax
dingsdax merged commit 939bcf0 into master Nov 11, 2026
173 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@dingsdax
dingsdax deleted the warden/sdk-review-pilot branch November 11, 2026 15:51
@sentry-release-bot sentry-release-bot Bot mentioned this pull request Nov 12, 2026
publish: getsentry/[email protected] getsentry/publish#10388
Closed
6 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@dingsdax dingsdax

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@alexander-alderman-webb @dingsdax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.