GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(bedrock): Set `gen_ai.response.finish_reasons` for non-streaming responses by alexander-alderman-webb · Pull Request #8250 · getsentry/sentry-python

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Set attribute based on stopReason in response["usage"] returned from the Bedrock API.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
alexander-alderman-webb added 3 commits November 11, 2026 16:43
@alexander-alderman-webb
feat(bedrock): Set gen_ai.output.messages for non-streaming responses
a1f5b5e
@alexander-alderman-webb
make mypy happy
fc6b034
@alexander-alderman-webb
feat(bedrock): Record gen_ai.response.finish_reasons for non-streamin…
444f537 
…g responses
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/bedrock/nonstreaming-finish-reasons branch from 0edf177 to 444f537 Compare November 11, 2026 16:54
@github-actions

github-actions Bot commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 139166 passed | ⏭️ 7813 skipped | Total: 146979 | Pass Rate: 94.68% | Execution Time: 457m 10s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ Test counts unchanged from base.

All tests are passing successfully.

✅ Patch coverage is 100.00% (2 of 2 changed executable lines covered; target 80%).
Project statement coverage is 90.21%.

Changed files with executable lines (1)
File Patch coverage Changed executable lines
sentry_sdk/integrations/boto3/_services/bedrock.py 100.00% 2/2 covered

Generated by Coverage Action
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@alexander-alderman-webb
alexander-alderman-webb added this pull request to stack #8254 November 12, 2026 08:10
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review November 12, 2026 08:10
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner November 12, 2026 08:10
sentrivana
sentrivana approved these changes Nov 12, 2026
View reviewed changes
@alexander-alderman-webb
alexander-alderman-webb removed this pull request from stack #8254 November 12, 2026 09:09
Base automatically changed from webb/bedrock/nonstreaming-output-messages to master November 12, 2026 09:14
@alexander-alderman-webb
merge master
1e10960
@alexander-alderman-webb alexander-alderman-webb changed the title feat(bedrock): Record gen_ai.response.finish_reasons for non-streaming responses feat(bedrock): Set gen_ai.response.finish_reasons for non-streaming responses Nov 12, 2026
@alexander-alderman-webb
alexander-alderman-webb merged commit 42f925e into master Nov 12, 2026
173 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/bedrock/nonstreaming-finish-reasons branch November 12, 2026 09:31
@sentry-release-bot sentry-release-bot Bot mentioned this pull request Nov 12, 2026
publish: getsentry/[email protected] getsentry/publish#10388
Closed
6 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivana sentrivana sentrivana approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@alexander-alderman-webb @sentrivana
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.