GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(bedrock): Set `gen_ai.output.messages` for streamed responses by alexander-alderman-webb · Pull Request #8251 · getsentry/sentry-python

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Description

Keep track of blocks as they arrive in parts indexed by event["contentBlockDelta"]["contentBlockIndex"].
The parts are directly stored in the final gen_ai.output.messages format.

Issues

Reminders

  • Please add tests to validate your changes, and lint your code using uv run ruff.
  • Add GH Issue ID & Linear ID (if applicable)
  • PR title should use conventional commit style (feat:, fix:, ref:, meta:)
  • For external contributors: CONTRIBUTING.md, Sentry SDK development docs, Discord community

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
alexander-alderman-webb added 3 commits November 11, 2026 16:43
@alexander-alderman-webb
feat(bedrock): Set gen_ai.output.messages for non-streaming responses
a1f5b5e
@alexander-alderman-webb
make mypy happy
fc6b034
@alexander-alderman-webb
feat(bedrock): Record gen_ai.response.finish_reasons for non-streamin…
444f537
…g responses
@alexander-alderman-webb alexander-alderman-webb changed the title feat(bedrock): Set gen_ai.output.messages for streamed responses feat(bedrock): Set gen_ai.output.messages for streamed responses Nov 11, 2026
@github-actions

github-actions Bot commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 139222 passed | ⏭️ 7861 skipped | Total: 147083 | Pass Rate: 94.66% | Execution Time: 452m 47s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +104
Passed Tests 📈 +56
Failed Tests —
Skipped Tests 📈 +48

All tests are passing successfully.

✅ Patch coverage is 90.53% (86 of 95 changed executable lines covered; target 80%).
Project statement coverage is 90.22% (down 0.02 percentage points from base (42f925e) to head (7013669)).

Changed files with executable lines (1)
File Patch coverage Changed executable lines
sentry_sdk/integrations/boto3/_services/bedrock.py 90.53% 86/95 covered; missed: 211, 216, 217, 236, 245, 246, 292, 296, 297; partial branches: 210, 235, 271, 291
Coverage diff
@@            Coverage Diff             @@
##        master     #8251       +/-##
==========================================
- Coverage    90.24%    90.22%    -0.02%
==========================================
  Files          203       203         —
  Tracked lines     27235     27316       +81
  Branches     10200     10240       +40
==========================================
+ Hits         24577     24645       +68
- Misses        2658      2671       +13
- Partials      1555      1556        +1

Generated by Coverage Action

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/bedrock/streaming-output-messages branch from db1a5a4 to 6a90c1d Compare November 11, 2026 19:51
@alexander-alderman-webb
feat(bedrock): Set gen_ai.output.messages for streamed responses
e72921f
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/bedrock/streaming-output-messages branch from 6a90c1d to e72921f Compare November 11, 2026 19:59
@alexander-alderman-webb
alexander-alderman-webb added this pull request to stack #8254 November 12, 2026 08:10
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review November 12, 2026 08:10
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner November 12, 2026 08:10
cursor[bot]
cursor Bot reviewed Nov 12, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e72921f. Configure here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread sentry_sdk/integrations/boto3/_services/bedrock.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread sentry_sdk/integrations/boto3/_services/bedrock.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

sentrivana
sentrivana approved these changes Nov 12, 2026
View reviewed changes
@alexander-alderman-webb
alexander-alderman-webb removed this pull request from stack #8254 November 12, 2026 09:09
Base automatically changed from webb/bedrock/nonstreaming-finish-reasons to master November 12, 2026 09:31
alexander-alderman-webb added 2 commits November 12, 2026 10:32
@alexander-alderman-webb
Merge branch 'master' into webb/bedrock/streaming-output-messages
7ade24b
@alexander-alderman-webb
remove small indirection
7013669
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/bedrock/streaming-output-messages branch from 0fbbfe9 to 7013669 Compare November 12, 2026 09:51
sentry-warden[bot]
sentry-warden Bot reviewed Nov 12, 2026
View reviewed changes
Comment thread sentry_sdk/integrations/boto3/_services/bedrock.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@alexander-alderman-webb
alexander-alderman-webb merged commit 7e42926 into master Nov 12, 2026
326 of 328 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@alexander-alderman-webb
alexander-alderman-webb deleted the webb/bedrock/streaming-output-messages branch November 12, 2026 10:16
@sentry-release-bot sentry-release-bot Bot mentioned this pull request Nov 12, 2026
publish: getsentry/[email protected] getsentry/publish#10388
Closed
6 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments
@sentry-warden sentry-warden[bot] sentry-warden[bot] left review comments
@sentrivana sentrivana sentrivana approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@alexander-alderman-webb @sentrivana
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.