GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat(bedrock): Set `gen_ai.response.time_to_first_chunk` by alexander-alderman-webb · Pull Request #8255 · getsentry/sentry-python

Conversation

alexander-alderman-webb commented Nov 12, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

Pet OTel, the duration is computed relative to a start time before the request is sent.
Add a request_start_time instance variable on extensions to propagate the start time into the patched iterator.

Closes #5470

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

alexander-alderman-webb added 9 commits

November 11, 2026 16:43


          feat(bedrock): Set gen_ai.output.messages for non-streaming responses

a1f5b5e


          make mypy happy

fc6b034


          feat(bedrock): Record gen_ai.response.finish_reasons for non-streamin…

444f537

…g responses


          feat(bedrock): Set gen_ai.output.messages for streamed responses

db1a5a4


          feat(bedrock): Record gen_ai.response.finish_reasons for streamed res…

5253e29

…ponses


          feat(bedrock): Set gen_ai.output.messages for streamed responses

e72921f


          merge

0de285e


          empty commit

7d0b930


          empty commit

80267a2

alexander-alderman-webb added this pull request to stack #8254

November 12, 2026 08:19

alexander-alderman-webb requested a review from a team as a code owner

November 12, 2026 08:19

cursor Bot reviewed

Nov 12, 2026

View reviewed changes

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

sentry_sdk/integrations/boto3/_services/bedrock.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

sentry-warden Bot reviewed

Nov 12, 2026

View reviewed changes

Comment thread

tests/integrations/boto3/test_bedrock.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

alexander-alderman-webb force-pushed the webb/bedrock/time-to-first-chunk branch from 07671d4 to 54f6f8a Compare

November 12, 2026 08:25

cursor Bot reviewed

Nov 12, 2026

View reviewed changes

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

sentry_sdk/integrations/boto3/_services/bedrock.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot commented Nov 12, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Coverage Results 📊

✅ 139222 passed | ⏭️ 7861 skipped | Total: 147083 | Pass Rate: 94.66% | Execution Time: 461m 11s

📊 Comparison with Base Branch

Metric	Change
Total Tests	📈 +104
Passed Tests	📈 +56
Failed Tests	—
Skipped Tests	📈 +48

All tests are passing successfully.

✅ Patch coverage is 94.44% (17 of 18 changed executable lines covered; target 80%).
Project statement coverage is 90.25% (up 0.01 percentage points from base (c877c50) to head (a0dff72)).

Changed files with executable lines (4)

File	Patch coverage	Changed executable lines
sentry_sdk/integrations/boto3/_services/base.py	66.67%	2/3 covered; missed: 24
sentry_sdk/consts.py	100.00%	2/2 covered
sentry_sdk/integrations/boto3/_client.py	100.00%	3/3 covered
sentry_sdk/integrations/boto3/_services/bedrock.py	100.00%	10/10 covered

Coverage diff

@@            Coverage Diff             @@
##        master     #8255       +/-##
==========================================
+ Coverage    90.24%    90.25%    +0.01%
==========================================
  Files          203       203         —
  Tracked lines     27235     27335      +100
  Branches     10200     10246       +46
==========================================
+ Hits         24577     24670       +93
- Misses        2658      2665        +7
  Partials      1555      1555         —

Generated by Coverage Action

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alexander-alderman-webb force-pushed the webb/bedrock/time-to-first-chunk branch from 54f6f8a to c71c056 Compare

November 12, 2026 08:38

cursor Bot reviewed

Nov 12, 2026

View reviewed changes

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

sentry_sdk/integrations/boto3/_services/bedrock.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

alexander-alderman-webb marked this pull request as draft

November 12, 2026 08:42


          feat(bedrock): Set gen_ai.response.time_to_first_chunk

38a00ab

alexander-alderman-webb force-pushed the webb/bedrock/time-to-first-chunk branch from c71c056 to 38a00ab Compare

November 12, 2026 08:54

alexander-alderman-webb marked this pull request as ready for review

November 12, 2026 08:57

alexander-alderman-webb removed this pull request from stack #8254

November 12, 2026 09:09

sentrivana approved these changes

Nov 12, 2026

View reviewed changes

Base automatically changed from webb/bedrock/streaming-finish-reasons to master

November 12, 2026 10:31

alexander-alderman-webb added 2 commits

November 12, 2026 11:33


          merge master

d237855


          remove an unnecessary cast

00ed1f7

cursor Bot reviewed

Nov 12, 2026

View reviewed changes

cursor Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit d74279d. Configure here.}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

sentry_sdk/integrations/boto3/_services/bedrock.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          remove another cast

3981f4c

alexander-alderman-webb force-pushed the webb/bedrock/time-to-first-chunk branch from d74279d to 3981f4c Compare

November 12, 2026 10:46

alexander-alderman-webb added 2 commits

November 12, 2026 12:10


          use non-deprecated attribute

6942d8e


          simplify test

a0dff72

alexander-alderman-webb merged commit 860a060 into master

Nov 12, 2026

173 checks passed

Uh oh!

There was an error while loading. Please reload this page.

alexander-alderman-webb deleted the webb/bedrock/time-to-first-chunk branch

November 12, 2026 11:33

sentry-release-bot Bot mentioned this pull request

Nov 12, 2026

publish: getsentry/[email protected] getsentry/publish#10388

Closed

6 tasks done

Reviewers

cursor[bot]

cursor[bot] left review comments

sentry-warden[bot]

sentry-warden[bot] left review comments

sentrivana

sentrivana approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AWS SDK Agent Support

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

alexander-alderman-webb commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Results 📊

📊 Comparison with Base Branch

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alexander-alderman-webb commented Nov 12, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot commented Nov 12, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

cursor Bot left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.