GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Optimize cached artifact serving by andrew · Pull Request #245 · git-pkgs/proxy

Conversation

@andrew

@andrew andrew commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Reduce cached artifact requests from three database lookups to one indexed join. Reuse a 32 KiB copy buffer and remove avoidable formatting and PURL parsing allocations while preserving integrity verification and hit accounting.

In the real npm HTTP cache-hit benchmark, sequential latency falls by about 15% and allocated bytes by about 74%. Concurrent throughput increases by about 51%. No database migration is required.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@andrew
andrew requested a lite review from Copilot August 12, 2026 18:49
Copilot started reviewing on behalf of andrew August 12, 2026 18:49
View session
Copilot AI reviewed Aug 12, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes cached artifact serving by reducing database round-trips for cache hits and lowering per-request allocations during response streaming, while keeping integrity verification and hit accounting intact.

Changes:

  • Replace multiple cache-hit DB lookups with a single indexed join query (GetCachedArtifact).
  • Reduce allocations in artifact serving (pooled 32 KiB copy buffer; avoid fmt.Sprintf formatting; avoid PURL parsing for metrics).
  • Add benchmarks and a database test to validate the new cached-artifact lookup path.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/handler/handler.go Switch cache-hit path to a single DB query, streamline metrics and headers, and use a pooled buffer for streaming responses.
internal/handler/handler_test.go Generalize test helpers to testing.TB so they can be reused by benchmarks.
internal/handler/handler_bench_test.go Add benchmarks for cache-hit serving (streaming/direct serve), metadata reading, and PURL construction.
internal/database/types.go Introduce CachedArtifact projection struct for lightweight cache-hit reads.
internal/database/queries.go Add GetCachedArtifact query using joins and cached-only predicates.
internal/database/database_test.go Add coverage for GetCachedArtifact behavior (miss/hit and package mismatch).
Suppressed comments (1)

internal/handler/handler.go:212

  • Cache-hit metrics should use the cached artifact's ecosystem from the DB (artifact.Ecosystem) to avoid mislabeling metrics when the caller ecosystem string is an alias or otherwise inconsistent.
			if err := p.DB.ClearArtifactCache(versionPURL, filename); err != nil {
				p.Logger.Warn("failed to clear corrupt artifact from cache", "error", err)
			}
		})
	p.recordCacheHit(ecosystem, versionPURL, filename)
	return result, nil

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread internal/handler/handler.go Resolved

Uh oh!

There was an error while loading. Please reload this page.

@andrew
Optimize cached artifact serving
aa20522
@andrew
andrew force-pushed the perf/cache-hit-path branch from 108f90d to aa20522 Compare August 13, 2026 07:02
@andrew
andrew merged commit 6fcc57c into main Aug 13, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@andrew
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.