GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bump github.com/git-pkgs/purl to v0.1.17 by andrew · Pull Request #273 · git-pkgs/proxy

Conversation

@andrew

@andrew andrew commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

MakePURL/MakePURLString/New now apply the same per-type normalization as Parse (git-pkgs/purl#30), so canonicalPackagePURL no longer needs its own Normalize call and DB writes/lookups produce canonical keys.

Existing rows written under a non-canonical purl (mixed-case pypi, composer, etc) become cache misses on lookup and re-populate under the canonical key on the next fetch; the old rows are left in place rather than migrated.

Closes #207

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andrew
Bump github.com/git-pkgs/purl to v0.1.17
25ad437 
MakePURL/MakePURLString/New now apply the same per-type normalization as
Parse (git-pkgs/purl#30), so canonicalPackagePURL no longer needs its own
Normalize call and DB writes/lookups produce canonical keys.

Existing rows written under a non-canonical purl (mixed-case pypi,
composer, etc) become cache misses on lookup and re-populate under the
canonical key on the next fetch; the old rows are left in place.

Closes #207
@andrew
andrew requested a lite review from Copilot August 16, 2026 22:27
Copilot started reviewing on behalf of andrew August 16, 2026 22:28
View session
Copilot AI reviewed Aug 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the github.com/git-pkgs/purl dependency to pick up new per-type normalization behavior and simplifies local PURL canonicalization so cache keys/lookup keys align with the library’s canonical form.

Changes:

  • Bump github.com/git-pkgs/purl from v0.1.16 to v0.1.17.
  • Simplify canonicalPackagePURL to use purl.MakePURLString(...) directly (removing the local Normalize() call).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
internal/handler/handler.go Removes the explicit Normalize() call in canonicalPackagePURL, relying on MakePURLString for canonicalization.
go.mod Updates github.com/git-pkgs/purl requirement to v0.1.17.
go.sum Updates checksums for github.com/git-pkgs/purl v0.1.17.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread internal/handler/handler.go Resolved

Uh oh!

There was an error while loading. Please reload this page.
@andrew
andrew merged commit 12ad4ec into main Aug 17, 2026
9 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@andrew
andrew deleted the bump/purl-v0.1.17 branch August 17, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Package/version DB rows are keyed by non-canonical PURL

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@andrew
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.