GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — docker host is trimmed too much in the docs by kokes · Pull Request #317 · git-pkgs/proxy

Conversation

@kokes

@kokes kokes commented Sep 4, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

When browsing the installation docs in the proxy UI, I noticed the Docker/OCI instructions had a weird trimming issue - "docker pull ackage-proxy..."

image

Turns out there was a rather rudimentary string slice that assumed https - but when hosted on http, this trims too much.

(I originally planned to parse via net/url, but that seems like overkill since there are only two schemes to consider here.)

(Also the test is a bit meh - feel free to drop it.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kokes
docker host is trimmed too much in the docs
615b771
@kokes
kokes marked this pull request as ready for review September 4, 2026 15:30
andrew
andrew approved these changes Sep 4, 2026
View reviewed changes
@andrew

andrew commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Good catch, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@andrew
andrew merged commit bb2205a into git-pkgs:main Sep 4, 2026
6 checks passed

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrew andrew andrew approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kokes @andrew
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.