GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable storage retention for npm by pinguinfuss · Pull Request #440 · git-pkgs/proxy

Conversation

@pinguinfuss

@pinguinfuss pinguinfuss commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Refs #306, builds on #428.

Registers npm for storage.retention, so cached tarballs are evicted once nobody has downloaded them for the configured age.

Package rules use the package name as purl writes it. Both pkg:npm/@babel/core and pkg:npm/%40babel/core work. Names match exactly, so pkg:npm/jsonstream doesn't cover JSONStream.

Tests cover eviction and refetch, package rules for scoped and unscoped packages, and tarballs the mirror puts in the cache.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pinguinfuss added 2 commits October 12, 2026 10:23
@pinguinfuss
Enable storage retention for npm
b002885 
npm stores packages under the PURL purl builds from the full name, so package rules use the default mapping. Both pkg:npm/@babel/core and pkg:npm/%40babel/core work.

Refs git-pkgs#306
@pinguinfuss
Tighten npm retention tests and docs
7ecb00a 
The docs now say npm package rules match the name exactly, so pkg:npm/jsonstream doesn't cover JSONStream. The refetch, package rule and mirror tests were weaker than their names and now check what they claim.

Refs git-pkgs#306
andrew
andrew approved these changes Oct 12, 2026
View reviewed changes

@andrew andrew left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm package rules match the production cache keys. The tests cover eviction, deletion queueing, refetching, scoped package exemptions, and mirrored tarballs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andrew
Merge main and resolve retention documentation conflict
4f86688
andrew
andrew approved these changes Oct 12, 2026
View reviewed changes

@andrew andrew left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation conflict is resolved with the npm entry and the previously merged ecosystem entries preserved. This retains the change reviewed at #440 (review).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andrew
andrew merged commit 4b8678c into git-pkgs:main Oct 12, 2026
6 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@pinguinfuss
pinguinfuss deleted the issue-306-retention-npm branch October 12, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrew andrew andrew approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pinguinfuss @andrew
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.