GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable storage retention for golang by pinguinfuss · Pull Request #442 · git-pkgs/proxy

Conversation

@pinguinfuss

@pinguinfuss pinguinfuss commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Refs #306, builds on #428.

Registers golang for storage.retention.

Package rules use the module path as in go.mod, e.g. pkg:golang/github.com/stretchr/testify. The proxy stores module paths lowercased, so a rule matches whatever case it's written in. A major version (/v2, or .v3 on gopkg.in) is a module of its own and needs its own rule. Keys in the !-escaped form from proxy URLs and the module cache (github.com/!azure/...) are refused at startup, since they could never match.

Because paths are lowercased, two modules that differ only in case already share one cache entry on main. That isn't changed here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@pinguinfuss
Enable storage retention for golang
7694e02
Module paths are stored lowercased, so package rules match whatever case they're written in. A major version like /v2 is its own module and needs its own rule. Keys in the !-escaped form from proxy URLs and the module cache are refused, since they could never match.

Refs git-pkgs#306
andrew
andrew approved these changes Oct 12, 2026
View reviewed changes

@andrew andrew left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go module retention rules match the stored cache keys. The tests cover eviction, refetching, case matching, major-version separation, escaped-key rejection, and mirrored modules.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@andrew
andrew merged commit c61cb51 into git-pkgs:main Oct 12, 2026
6 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@pinguinfuss
pinguinfuss deleted the issue-306-retention-golang branch October 12, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrew andrew andrew approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pinguinfuss @andrew
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.