GeezerVison is showing github.com — Refuse dot segments in package paths and upstream auth matching by simonchrz · Pull Request #554 · git-pkgs/proxy
Conversation
simonchrz
commented
Oct 22, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Encoded dot segments such as %2e%2e get past the router's path cleaning. Maven, conda, cran, go and gem append the decoded path to the upstream URL, so the upstream resolves it outside the configured base path. Upstream credentials also matched such URLs by path prefix.
- Package routes answer 400 for a
. or .. segment, also when encoded twice or written with a backslash. This is a middleware next to rejectQueryInPath.
- URLs with dot segments get no upstream credentials.
;params are ignored for this check, since Tomcat and Jetty drop them before resolving ..;.
- Package routes also refuse
;, like ? and #. Composer archives stay exempt.
Tests cover every affected ecosystem through mountProtocolHandlers, dotted names that must keep working, and the auth matching.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Routers clean literal dot segments, but encoded ones such as %2e%2e
reach the handlers. Maven, conda, cran, go and gem append the decoded
path to the upstream URL, so the upstream resolved it outside the
configured base path. Package routes now answer 400 for a '.' or '..'
segment, also when encoded twice or written with a backslash.
Upstream credentials matched such a URL by its path prefix, so
/scope/../other still got the credentials configured for /scope. URLs
with dot segments now get no credentials.
Tomcat and Jetty drop ";params" from a path segment before resolving it,
so "..;" passed the dot-segment check and still got the credentials
configured for the upstream path. The check now ignores ";params", and
package routes refuse ';' like '?' and '#', which also stops "1.0;x"
from passing the denylist as a different version. Composer archives
stay exempt, since git branch names may contain ';'.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
andrew
andrew approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
breaking
Changes behaviour users rely on; needs a minor release
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.