GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use PullRequest.timelineItems instead of PullRequest.timeline by jcansdale · Pull Request #2482 · github/VisualStudio

This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

@jcansdale

@jcansdale jcansdale commented Mar 18, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

The the deprecated PullRequest.timeline field is going away soon. When it does, this will happen. Convert to using the modern PullRequest.timelineItems field.

Todo

  • Only fetch pull request comments and commits.

How to test

  • Open pull request details view
  • Open pull request timeline page
  • Check that pull request comments and commits appear as expected

Seems to be working...

image

Notes

Thanks @parto, @xuorig, @rmosolgo and @nplasterer for the heads up about this!

Fixes #2481

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rmosolgo and nplasterer reacted with hooray emoji
All reactions
  • 🎉 2 reactions
@jcansdale
Use PullRequest.timelineItems instead of timeline
46e06b5
@jcansdale
jcansdale requested a review from a user March 18, 2020 10:42
@rmosolgo

rmosolgo commented Mar 18, 2020

Copy link
Copy Markdown

Glad it turned out to be a pretty clear substitution 🎉

What's the release turn-around after this PR is merged?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jcansdale

jcansdale commented Mar 18, 2020

Copy link
Copy Markdown
Collaborator Author

@rmosolgo,

What's the release turn-around after this PR is merged?

I'm hoping to get a new version out this week! Hopefully auto-update will work for most users. I know some can get stuck on old versions.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jcansdale
Only fetch IssueComment and PullRequestCommit items
d66aac3
@jcansdale
jcansdale requested a review from StanleyGoldman March 18, 2020 22:18
@jcansdale
jcansdale merged commit 7884364 into master Mar 19, 2020
@jcansdale
jcansdale deleted the fixes/2481-PullRequest.timelineItems branch March 19, 2020 12:02
@rmosolgo

rmosolgo commented Mar 24, 2020

Copy link
Copy Markdown

@jcansdale, have you cut a new release? Ok to go ahead with the deprecations? (Well, yknow, as ok as ever ?)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jcansdale

jcansdale commented Mar 25, 2020

Copy link
Copy Markdown
Collaborator Author

@rmosolgo sorry about the delay. it has been another crazy week! 😉

I'll try to get a release out today. I'll keep you posted!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rmosolgo

rmosolgo commented Apr 7, 2020

Copy link
Copy Markdown

Just checking in about that release -- soon, I need to remove these deprecated schema bits, I'd love for folks to have an upgrade path when that happens!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jcansdale

jcansdale commented Apr 8, 2020

Copy link
Copy Markdown
Collaborator Author

@rmosolgo the updated version is out, but I'm having one hell of a time with Visual Studio's auto-update mechanism. First our certificate expired and now the updated cert doesn't appear to be taking. 😭

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rmosolgo

rmosolgo commented Apr 14, 2020

Copy link
Copy Markdown

Can you tell if the update has been rolling itself out? Still hoping to move forward with https://github.com/github/ecosystem-api/issues/1876 soon, but if you want to try again, I'll wait!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jcansdale

jcansdale commented Apr 15, 2020

Copy link
Copy Markdown
Collaborator Author

Hi @rmosolgo,

Here's how the rollout is looking.

image

Users updated to the latest version is still depressingly low. I've written to the VS installer folks, but haven't heard back yet. I'll ping them again via Teams. 🤞

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@StanleyGoldman StanleyGoldman Awaiting requested review from StanleyGoldman

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Field 'timeline' doesn't exist on type 'PullRequest'

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jcansdale @rmosolgo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.