GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — modelgenerator: default to generating JSON by nickrolfe · Pull Request #23097 · github/codeql

Conversation

@nickrolfe

@nickrolfe nickrolfe commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Now that I'm merging PRs to convert all existing models to JSON, changing the default here ensures any new ones should also be generated in the JSON format.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nickrolfe
modelgenerator: default to generating JSON
29cfb3a
@nickrolfe nickrolfe added the no-change-note-required This PR does not need a change note label Nov 11, 2026
@nickrolfe
nickrolfe requested a review from a team as a code owner November 11, 2026 11:31
Copilot AI dynamic review requested due to automatic review settings November 11, 2026 11:31
Copilot started reviewing on behalf of nickrolfe November 11, 2026 11:32
View session
Copilot AI reviewed Nov 11, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The change defaults model generation and conversion to JSON while pack manifests and CI workflows still recognize only YAML, so generated models would be omitted from CodeQL and workflow processing.

3 open issues
  • High severity Bulk-generated JSON models are excluded by pack globs · New
  • High severity Converter output is excluded by YAML-only pack globs · New
  • High severity JSON defaults are missed by pack and workflow globs · New
What changed in this PR

This pull request changes Models-as-Data generation and conversion tools to produce JSON output by default, but repository manifests and workflows still match only .model.yml files.

Changes:

  • Defaults standalone and bulk model generation to JSON.
  • Changes extension conversion to emit .model.json files.
  • Requires coordinated updates to pack manifests and workflow globs so generated JSON files are consumed and staged.
File Description
misc/​scripts/​models-as-data/​generate_mad.py Defaults standalone model generation to JSON output.
misc/​scripts/​models-as-data/​convert_extensions.py Changes converted model extension files to use the .model.json format.
misc/​scripts/​models-as-data/​bulk_generate_mad.py Defaults bulk model generation to JSON output.

Review effort: Lite (auto)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread misc/scripts/models-as-data/bulk_generate_mad.py
"--extension-format",
choices=["json", "yaml"],
default="yaml",
default="json",
Comment thread misc/scripts/models-as-data/convert_extensions.py
# N.B. change this to .model.json to change the output format:
self.modelFileExtension = ".model.yml"
# N.B. change this to .model.yml to change the output format:
self.modelFileExtension = ".model.json"
Comment thread misc/scripts/models-as-data/generate_mad.py
"--extension-format",
choices=["json", "yaml"],
default="yaml",
default="json",
@nickrolfe nickrolfe mentioned this pull request Nov 11, 2026
Rust: convert data extensions to JSON #23087
Merged

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

no-change-note-required This PR does not need a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@nickrolfe
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.