GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Deprecate TRAP cache cleanup by henrymercer · Pull Request #3795 · github/codeql-action

Conversation

@henrymercer

@henrymercer henrymercer commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

This undocumented feature required giving actions: write permission to the analyze job on the default branch. If we were going to move ahead, we would prefer to reimplement this within a separate Action that does the cleanup to limit permissions. However it is most likely that TRAP caching will become less relevant over time given improved incremental analysis supersedes it, so this PR deprecates this little-used and undocumented feature.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@henrymercer
Deprecate TRAP cache cleanup
36075a4
@henrymercer
henrymercer requested a review from a team as a code owner April 1, 2026 14:34
Copilot AI review requested due to automatic review settings April 1, 2026 14:34
@github-actions github-actions Bot added the size/XS Should be very easy to review label Apr 1, 2026
Copilot started reviewing on behalf of henrymercer April 1, 2026 14:35
View session
Copilot AI approved these changes Apr 1, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Deprecates the TRAP cache cleanup feature by surfacing a runtime warning and documenting the deprecation timeline in the changelog, aligning with the goal of reducing required permissions for analyze and discouraging use of this undocumented behavior.

Changes:

  • Emit a deprecation warning when TRAP cache cleanup is enabled.
  • Document the deprecation and removal timeline in CHANGELOG.md.
  • Update generated lib/ output to reflect the TypeScript source change.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/trap-caching.ts Adds a warning indicating TRAP cache cleanup is deprecated and provides guidance to disable TRAP caching.
lib/analyze-action.js Generated build artifact reflecting the src/ change.
CHANGELOG.md Adds an UNRELEASED entry documenting the deprecation, removal date, and mitigation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sam-robson
sam-robson approved these changes Apr 6, 2026
View reviewed changes
@henrymercer
henrymercer added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit e25c0a5 Apr 7, 2026
229 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@henrymercer
henrymercer deleted the henrymercer/deprecate-trap-caching-cleanup branch April 7, 2026 09:31
This was referenced Apr 15, 2026
Merge main into releases/v4 #3824
Merged
Merge releases/v4 into releases/v3 #3826
Merged
@github-actions github-actions Bot mentioned this pull request May 18, 2026
chore(ci)(deps): bump github/codeql-action from 3.35.4 to 4.35.5 ag-ui-protocol/ag-ui#1711
Closed
@coderabbitai coderabbitai Bot mentioned this pull request Sep 16, 2026
ci(actions): bump github/codeql-action/autobuild from 4.37.8 to 4.38.0 VBCreators/AI-RAG#35
Open
@henrymercer henrymercer mentioned this pull request Oct 16, 2026
Remove TRAP cache cleanup #4243
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sam-robson sam-robson sam-robson approved these changes
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/XS Should be very easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@henrymercer @sam-robson
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.