GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add tests for getCredentials with multiple goproxy_servers and maven_… by mario-campos · Pull Request #3799 · github/codeql-action

Conversation

@mario-campos

@mario-campos mario-campos commented Apr 2, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR adds two new tests to the start-proxy action, to assert that registry configurations with more than one registry of the same kind (two goproxy_server and two maven_repository in this case) are parsed and reported appropriately. While one additional test would be sufficient to test this multi-registry use-case, I thought two tests across two languages offered a bit more safety.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other - I expect a PR check to fail if these tests are implemented incorrectly.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mario-campos
mario-campos requested a review from a team as a code owner April 2, 2026 16:05
Copilot AI review requested due to automatic review settings April 2, 2026 16:05
@github-actions github-actions Bot added the size/S Should be easy to review label Apr 2, 2026
Copilot started reviewing on behalf of mario-campos April 2, 2026 16:05
View session
Copilot AI approved these changes Apr 2, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds unit test coverage to ensure start-proxy’s getCredentials correctly returns multiple registry configurations of the same type for a given language.

Changes:

  • Added a test verifying KnownLanguage.go returns all configured goproxy_server entries (and still includes git_source for Go).
  • Added a test verifying KnownLanguage.java returns all configured maven_repository entries (and filters out non-Java registry types).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mario-campos
mario-campos force-pushed the mario-campos/test-multiple-registries branch from 30f8fba to a9a28d0 Compare April 2, 2026 16:34
@mario-campos
mario-campos requested a review from mbg April 2, 2026 21:13
mbg
mbg reviewed Apr 7, 2026
View reviewed changes

@mbg mbg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor points, otherwise this LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/start-proxy.test.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/start-proxy.test.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

mario-campos and others added 4 commits April 7, 2026 09:01
@mario-campos
Add tests for getCredentials with multiple goproxy_servers and maven_…
f8aff3a
…repositories
@mario-campos
Run npm run lint-fix to format the code
43d8864
@mario-campos @mbg
Specify "Go" for a test case
14ed573
Co-authored-by: Michael B. Gale <[email protected]>
@mario-campos @mbg
Specify "Java" for a test case
35a3898
Co-authored-by: Michael B. Gale <[email protected]>
@mario-campos
mario-campos force-pushed the mario-campos/test-multiple-registries branch from b422f8e to 35a3898 Compare April 7, 2026 14:01
@mario-campos
mario-campos requested a review from mbg April 7, 2026 14:37
mbg
mbg approved these changes Apr 7, 2026
View reviewed changes
@mario-campos
mario-campos added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit b623f5f Apr 7, 2026
225 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos
mario-campos deleted the mario-campos/test-multiple-registries branch April 7, 2026 15:09
This was referenced Apr 15, 2026
Merge main into releases/v4 #3824
Merged
Merge releases/v4 into releases/v3 #3826
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbg mbg mbg approved these changes
Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/S Should be easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mario-campos @mbg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.