GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix `pr-checks/tsconfig.json` for TS6 by mbg · Pull Request #3810 · github/codeql-action

Conversation

@mbg

@mbg mbg commented Apr 10, 2026

Copy link
Copy Markdown
Member

Follow-up to #3800. The pr-checks/tsconfig.json file also needed to be updated, which was missed there and is fixed here.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other - Please provide details.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mbg added 2 commits April 10, 2026 13:22
@mbg
Set module option for pr-checks/tsconfig.json
1cf0431
@mbg
Explicitly add pr-checks to Dependabot config
b669eab
@mbg
mbg requested a review from henrymercer April 10, 2026 15:59
@mbg mbg self-assigned this Apr 10, 2026
@mbg
mbg requested a review from a team as a code owner April 10, 2026 15:59
Copilot AI review requested due to automatic review settings April 10, 2026 15:59
@github-actions github-actions Bot added the size/XS Should be very easy to review label Apr 10, 2026
Copilot started reviewing on behalf of mbg April 10, 2026 16:00
View session
Copilot AI reviewed Apr 10, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates configuration files to keep pr-checks compatible with the TypeScript 6 upgrade (follow-up to #3800), and ensures Dependabot also tracks dependencies in pr-checks.

Changes:

  • Override pr-checks/tsconfig.json to use module: "preserve" (aligned with TS6 + moduleResolution: bundler expectations inherited from the root config).
  • Update Dependabot configuration to monitor both the root and pr-checks npm directories.
Show a summary per file
File Description
pr-checks/tsconfig.json Overrides module to "preserve" to avoid inheriting the root commonjs module setting under TS6.
.github/dependabot.yml Expands npm update scope to include both / and /pr-checks.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
henrymercer
henrymercer approved these changes Apr 10, 2026
View reviewed changes

@henrymercer henrymercer left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. It might also be worth updating the root tsconfig so that we typecheck pr-checks/**.ts as part of npm run build.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mbg
mbg added this pull request to the merge queue Apr 10, 2026
Merged via the queue into main with commit ee09113 Apr 10, 2026
229 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@mbg
mbg deleted the mbg/ts6/fix-pr-checks branch April 10, 2026 18:22
This was referenced Apr 15, 2026
Merge main into releases/v4 #3824
Merged
Merge releases/v4 into releases/v3 #3826
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@henrymercer henrymercer henrymercer approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mbg mbg

Labels

size/XS Should be very easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mbg @henrymercer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.