GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Default to `StartProxyRemoveUnusedRegistries` behaviour by mbg · Pull Request #3909 · github/codeql-action

Conversation

@mbg

@mbg mbg commented May 18, 2026

Copy link
Copy Markdown
Member

Removes the StartProxyRemoveUnusedRegistries and defaults to the new behaviour.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mbg
Default to StartProxyRemoveUnusedRegistries behaviour
3dc99aa
@mbg mbg self-assigned this May 18, 2026
@github-actions github-actions Bot added the size/S Should be easy to review label May 18, 2026
@mbg
mbg marked this pull request as ready for review May 18, 2026 17:53
@mbg
mbg requested a review from a team as a code owner May 18, 2026 17:53
Copilot AI review requested due to automatic review settings May 18, 2026 17:53
Copilot started reviewing on behalf of mbg May 18, 2026 17:58
View session
Copilot AI reviewed May 18, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the StartProxyRemoveUnusedRegistries feature flag and makes its behaviour the default, so unused registries are always skipped based on the language being analysed.

Changes:

  • Drop the feature flag and its featureConfig entry.
  • Remove the old LANGUAGE_TO_REGISTRY_TYPE and rename the NEW_* variant to LANGUAGE_TO_REGISTRY_TYPE; simplify getCredentials by removing the skipUnusedRegistries parameter.
  • Update start-proxy-action.ts to no longer query the flag, and adjust tests accordingly.
Show a summary per file
File Description
src/start-proxy.ts Consolidates registry mapping to one constant and removes the skipUnusedRegistries parameter from getCredentials.
src/start-proxy.test.ts Updates tests to match the new signature and removes the now-redundant Actions test case.
src/start-proxy-action.ts Removes the feature flag query and unused Feature import.
src/feature-flags.ts Removes the StartProxyRemoveUnusedRegistries enum value and config entry.
lib/upload-lib.js, lib/entry-points.js Generated JS reflecting the source changes.

Copilot's findings

  • Files reviewed: 4/6 changed files
  • Comments generated: 0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
redsun82
redsun82 previously approved these changes Jun 18, 2026
View reviewed changes
@mbg
Merge branch 'main' into mbg/ff/remove/StartProxyRemoveUnusedRegistries
b3b14d6
@mbg
mbg dismissed redsun82’s stale review via b3b14d6 June 18, 2026 13:30
@mbg
mbg requested a review from redsun82 June 18, 2026 13:42
@mbg

mbg commented Jun 18, 2026

Copy link
Copy Markdown
Member Author

@redsun82 thanks for reviewing! I had to resolve one merge conflict (by rebuilding the JS), which dismissed your review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mbg
mbg enabled auto-merge June 18, 2026 13:43
oscarsj
oscarsj approved these changes Jun 18, 2026
View reviewed changes
@mbg
mbg added this pull request to the merge queue Jun 18, 2026
Merged via the queue into main with commit 516447a Jun 18, 2026
228 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@mbg
mbg deleted the mbg/ff/remove/StartProxyRemoveUnusedRegistries branch June 18, 2026 14:22
This was referenced Jul 1, 2026
Merge main into releases/v4 #3982
Closed
Merge main into releases/v4 #3984
Merged
Merge releases/v4 into releases/v3 #3992
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@oscarsj oscarsj oscarsj approved these changes
@redsun82 redsun82 Awaiting requested review from redsun82

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mbg mbg

Labels

size/S Should be easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mbg @oscarsj @redsun82
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.