GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Clean up `codeql.resolveLanguages` by henrymercer · Pull Request #3954 · github/codeql-action

Conversation

@henrymercer

@henrymercer henrymercer commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Only the betterjson option is now used, so remove the old version.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
  • GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@henrymercer
Clean up codeql.resolveLanguages
72b0f9f
Only the betterjson option is now used, so remove the old version.
@henrymercer
henrymercer requested a review from a team as a code owner June 5, 2026 11:51
Copilot AI review requested due to automatic review settings June 5, 2026 11:51
Copilot started reviewing on behalf of henrymercer June 5, 2026 11:52
View session
@github-actions github-actions Bot added the size/S Should be easy to review label Jun 5, 2026
Copilot AI reviewed Jun 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up the CodeQL CLI language-resolution API by removing the legacy betterResolveLanguages method and standardizing on a single resolveLanguages implementation that uses the --format=betterjson output.

Changes:

  • Replace all call sites of betterResolveLanguages() with resolveLanguages().
  • Update stubs/mocks in unit tests to align with the new resolveLanguages method name and output expectations.
  • Simplify the CodeQL interface by removing the old JSON-format resolveLanguages variant and keeping only the betterjson-based behavior.
Show a summary per file
File Description
src/workflow.ts Switch language alias resolution to call codeql.resolveLanguages().
src/workflow.test.ts Update stubbing to match the renamed resolveLanguages() API.
src/trap-caching.ts Use resolveLanguages() to query extractor metadata for TRAP caching support.
src/trap-caching.test.ts Update stubbed CodeQL implementation to provide resolveLanguages().
src/config-utils.ts Use resolveLanguages({ filterToLanguagesWithQueries }) for supported language detection.
src/config-utils.test.ts Update stub implementations and expectations for resolveLanguages() output.
src/codeql.ts Remove the old JSON resolveLanguages method and rename betterjson variant to resolveLanguages.
lib/entry-points.js Generated output updated to reflect the TypeScript changes (not reviewed).

Copilot's findings

  • Files reviewed: 7/8 changed files
  • Comments generated: 1

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/codeql.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@henrymercer
Remove one extractor per language assumption
ddef289
navntoft
navntoft approved these changes Jun 5, 2026
View reviewed changes
@henrymercer
henrymercer added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit e263f3a Jun 5, 2026
225 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@henrymercer
henrymercer deleted the henrymercer/tidy-resolve-languages branch June 5, 2026 14:07
This was referenced Jul 1, 2026
Merge main into releases/v4 #3982
Closed
Merge main into releases/v4 #3984
Merged
Merge releases/v4 into releases/v3 #3992
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@navntoft navntoft navntoft approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/S Should be easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@henrymercer @navntoft
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.