GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove `ready_for_review` triggers from workflows by mbg · Pull Request #3969 · github/codeql-action

Conversation

@mbg

@mbg mbg commented Jun 22, 2026

Copy link
Copy Markdown
Member

For CI-generated commits, we have used the workaround of creating draft PRs and marking them as "Ready for review" to trigger workflows using the ready_for_review type for pull_request events. This appears to no longer be necessary, because we can now click on the "Approve workflow runs" button in the UI instead.

This PR removes the ready_for_review triggers we had specifically for this purpose (allowing us to revert to not specifying the event types at all, because the remaining list matches the default list). It also updates the automation where we create PRs to no longer create or mark them as drafts.

Removing the ready_for_review triggers has the additional benefit that, for regular PRs, we no longer end up running the workflows twice if they have already run while the PR was a draft.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • Other - Please provide details.

Validated this approach in a different repository which has the same scenario.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other - Please provide details.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mbg added 2 commits June 22, 2026 13:19
@mbg
Remove ready_for_review triggers
e3a04b7
@mbg
Do not create draft PRs where we did so to trigger workflows with `re…
aa12ef0 
…ady_for_review` before
@mbg
mbg requested a review from henrymercer June 22, 2026 12:32
@mbg mbg self-assigned this Jun 22, 2026
@mbg
mbg requested a review from a team as a code owner June 22, 2026 12:32
Copilot AI review requested due to automatic review settings June 22, 2026 12:32
@github-actions github-actions Bot added the size/S Should be easy to review label Jun 22, 2026
Copilot started reviewing on behalf of mbg June 22, 2026 12:32
View session
Copilot AI reviewed Jun 22, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

Pull request overview

This PR updates the repository’s GitHub Actions automation to stop relying on the pull_request.ready_for_review event as a workaround for workflow-triggering behavior, and instead aligns PR-creation flows with the newer “Approve workflow runs” UI mechanism.

Changes:

  • Removes explicit pull_request.types lists (including ready_for_review) from multiple workflows and from the PR-check workflow generator.
  • Updates PR-creating automation to stop opening PRs as drafts (and removes the draft/ready toggling step).
  • Adjusts automation messaging to instruct maintainers to approve workflow runs rather than marking PRs “ready for review”.
Show a summary per file
File Description
pr-checks/sync.ts Updates generated PR-check workflow trigger configuration to avoid ready_for_review.
.github/workflows/update-bundle.yml Stops creating update-bundle PRs as drafts.
.github/workflows/test-codeql-bundle-all.yml Removes explicit pull_request.types list to avoid ready_for_review.
.github/workflows/rebuild.yml Updates rebuild notification and removes draft/ready manipulation.
.github/workflows/query-filters.yml Removes explicit pull_request.types list to avoid ready_for_review.
.github/workflows/python312-windows.yml Removes explicit pull_request.types list and related commentary.
.github/workflows/pr-checks.yml Removes explicit pull_request.types list and related commentary.
.github/workflows/label-pr-size.yml Removes explicit pull_request.types list (note: also drops edited).
.github/workflows/debug-artifacts-safe.yml Removes explicit pull_request.types list to avoid ready_for_review.
.github/workflows/debug-artifacts-failure-safe.yml Removes explicit pull_request.types list to avoid ready_for_review.
.github/workflows/codescanning-config-cli.yml Removes explicit pull_request.types list to avoid ready_for_review.
.github/workflows/codeql.yml Removes explicit pull_request.types list and related commentary.
.github/workflows/check-expected-release-files.yml Removes explicit pull_request.types list while keeping paths filtering.
.github/update-release-branch.py Creates merge PRs as non-drafts and updates checklist wording to “approve workflow runs”.
.github/actions/prepare-mergeback-branch/action.yml Creates mergeback PRs as non-drafts and updates checklist wording accordingly.

Copilot's findings

Files excluded by content exclusion policy (56)
  • .github/workflows/__all-platform-bundle.yml
  • .github/workflows/__analysis-kinds.yml
  • .github/workflows/__analyze-ref-input.yml
  • .github/workflows/__autobuild-action.yml
  • .github/workflows/__autobuild-direct-tracing-with-working-dir.yml
  • .github/workflows/__autobuild-working-dir.yml
  • .github/workflows/__build-mode-autobuild.yml
  • .github/workflows/__build-mode-manual.yml
  • .github/workflows/__build-mode-none.yml
  • .github/workflows/__build-mode-rollback.yml
  • .github/workflows/__bundle-from-nightly.yml
  • .github/workflows/__bundle-from-toolcache.yml
  • .github/workflows/__bundle-toolcache.yml
  • .github/workflows/__bundle-zstd.yml
  • .github/workflows/__cleanup-db-cluster-dir.yml
  • .github/workflows/__config-export.yml
  • .github/workflows/__config-input.yml
  • .github/workflows/__cpp-deptrace-disabled.yml
  • .github/workflows/__cpp-deptrace-enabled-on-macos.yml
  • .github/workflows/__cpp-deptrace-enabled.yml
  • .github/workflows/__diagnostics-export.yml
  • .github/workflows/__export-file-baseline-information.yml
  • .github/workflows/__extractor-ram-threads.yml
  • .github/workflows/__global-proxy.yml
  • .github/workflows/__go-custom-queries.yml
  • .github/workflows/__go-indirect-tracing-workaround-diagnostic.yml
  • .github/workflows/__go-indirect-tracing-workaround-no-file-program.yml
  • .github/workflows/__go-indirect-tracing-workaround.yml
  • .github/workflows/__go-tracing-autobuilder.yml
  • .github/workflows/__go-tracing-custom-build-steps.yml
  • .github/workflows/__go-tracing-legacy-workflow.yml
  • .github/workflows/__init-with-registries.yml
  • .github/workflows/__javascript-source-root.yml
  • .github/workflows/__job-run-uuid-sarif.yml
  • .github/workflows/__language-aliases.yml
  • .github/workflows/__local-bundle.yml
  • .github/workflows/__multi-language-autodetect.yml
  • .github/workflows/__overlay-init-fallback.yml
  • .github/workflows/__packaging-codescanning-config-inputs-js.yml
  • .github/workflows/__packaging-config-inputs-js.yml
  • .github/workflows/__packaging-config-js.yml
  • .github/workflows/__packaging-inputs-js.yml
  • .github/workflows/__remote-config.yml
  • .github/workflows/__resolve-environment-action.yml
  • .github/workflows/__rubocop-multi-language.yml
  • .github/workflows/__ruby.yml
  • .github/workflows/__rust.yml
  • .github/workflows/__split-workflow.yml
  • .github/workflows/__start-proxy.yml
  • .github/workflows/__submit-sarif-failure.yml
  • .github/workflows/__swift-autobuild.yml
  • .github/workflows/__swift-custom-build.yml
  • .github/workflows/__unset-environment.yml
  • .github/workflows/__upload-ref-sha-input.yml
  • .github/workflows/__upload-sarif.yml
  • .github/workflows/__with-checkout-path.yml
  • Files reviewed: 15/71 changed files
  • Comments generated: 2

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/label-pr-size.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/update-bundle.yml
Comment on lines 113 to 117
pr_url=$(gh pr create \
--title "Update default bundle to $cli_version" \
--body "$pr_body" \
--assignee "$GITHUB_ACTOR" \
--draft \
)
henrymercer
henrymercer reviewed Jun 22, 2026
View reviewed changes

@henrymercer henrymercer left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to fix, otherwise LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/label-pr-size.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mbg
Restore edited trigger for label-pr-size workflow
85bb4c6
henrymercer
henrymercer approved these changes Jun 23, 2026
View reviewed changes
@mbg
Merge branch 'main' into mbg/ci/no-more-draft-prs
c9d4e1d
@mbg
mbg enabled auto-merge June 23, 2026 17:45
@mbg
mbg added this pull request to the merge queue Jun 23, 2026
Merged via the queue into main with commit dd3c803 Jun 23, 2026
226 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@mbg
mbg deleted the mbg/ci/no-more-draft-prs branch June 23, 2026 18:11
This was referenced Jul 1, 2026
Merge main into releases/v4 #3982
Closed
Merge main into releases/v4 #3984
Merged
Merge releases/v4 into releases/v3 #3992
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@henrymercer henrymercer henrymercer approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mbg mbg

Labels

size/S Should be easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mbg @henrymercer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.