GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Don't upload the ESLint SARIF from merge queue refs by henrymercer · Pull Request #4125 · github/codeql-action

Conversation

@henrymercer

@henrymercer henrymercer commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

The Unit Tests job uploads its ESLint SARIF via upload-sarif, gated only on OS and Node version. PR Checks runs on merge_group, and also on push for the gh-readonly-queue branch that the merge queue creates, so in both cases the upload targets a ref that GitHub deletes as soon as the queue entry resolves. When the upload loses that race the code scanning API returns 404 and the step fails.

This accounts for every merge queue failure of PR Checks in the visible run history — five of them, going back to May.

Gate the step on the ref rather than the event, since both the merge_group run and the paired push run use the ephemeral ref. Nothing is lost: alerts on a queue ref are never surfaced, and the same results are uploaded by the pull_request run and again by the push run on main.

codeql.yml already skips its uploads for merge queue runs. It only needs the event check because its push trigger is limited to main and releases/v*.

Lint enforcement is unaffected — lint-ci still fails the job on any lint error. Only the alert upload is skipped.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@henrymercer
Don't upload the ESLint SARIF from merge queue refs
d2fe508
Co-authored-by: Copilot App <[email protected]>
@henrymercer
henrymercer requested a balanced review from Copilot September 4, 2026 16:23
Copilot started reviewing on behalf of henrymercer September 4, 2026 16:23
View session
@github-actions github-actions Bot added the size/XS Should be very easy to review label Sep 4, 2026
Copilot AI reviewed Sep 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused workflow change has no unresolved issues.

Review tier: Balanced
Findings: None

What changed in this PR

Prevents transient merge-queue failures by skipping ESLint SARIF uploads for ephemeral queue refs.

Changes:

  • Adds a ref-based guard for gh-readonly-queue refs.
  • Documents coverage of merge-group and paired push runs.
File Description
.github/​workflows/​pr-checks.yml Skips ESLint SARIF uploads from merge-queue refs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@henrymercer
henrymercer marked this pull request as ready for review September 4, 2026 16:27
@henrymercer
henrymercer requested a review from a team as a code owner September 4, 2026 16:27
mbg
mbg approved these changes Sep 4, 2026
View reviewed changes

@mbg mbg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good observation. Thanks for noticing and fixing it! The fix looks sensible to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@henrymercer
henrymercer enabled auto-merge September 4, 2026 16:34
@henrymercer
henrymercer added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit e06b60f Sep 4, 2026
225 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@henrymercer
henrymercer deleted the henrymercer/merge-queue-sarif-upload-flake branch September 4, 2026 16:50
This was referenced Sep 9, 2026
Merge main into releases/v4 #4131
Merged
Merge releases/v4 into releases/v3 #4133
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mbg mbg mbg approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/XS Should be very easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@henrymercer @mbg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.