GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Improve Copilot instructions by mbg · Pull Request #4142 · github/codeql-action

Conversation

mbg commented Sep 11, 2026

Copy link

Copy Markdown

Member

Some changes to copilot-instructions.md based on some observations of Copilot's reviews since the last change was made.

Risk assessment

For internal use only. Please select the risk level of this change:

Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

None - I am not validating these changes.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

Other - Please provide details.

Are there any special considerations for merging or releasing this change?

No special considerations - This change can be merged at any time.

Merge / deployment checklist

Confirm this change is backwards compatible with existing workflows.
Consider adding a changelog entry for this change.
Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Copilot AI balanced review requested due to automatic review settings

September 11, 2026 12:14

mbg requested a review from a team as a code owner

September 11, 2026 12:14

github-actions Bot added the size/XS Should be very easy to review label

Sep 11, 2026

Copilot started reviewing on behalf of mbg

September 11, 2026 12:15

View session

Copilot AI reviewed

Sep 11, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The instruction at line 16 ends mid-sentence and needs clarification.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 1

New issues introduced by this change (1)

Severity	Finding
	`.github/copilot-instructions.md` — Complete the truncated follow-up guidance

What changed in this PR

Documentation-only update to repository-specific Copilot review guidance.

Changes:

Documents repository structure, generated code, and pr-checks.
Adds release-process guidance.
Adjusts nested Markdown formatting.

Review note: Complete the instruction at line 16 so follow-up PR handling is unambiguous.

File	Summary
`.github/copilot-instructions.md`	Updated Copilot instructions and review guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

.github/copilot-instructions.md Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Improve Copilot instructions

cc78526

mbg force-pushed the mbg/copilot/update-instructions branch from 0f617ca to cc78526 Compare

September 11, 2026 13:19

mario-campos reviewed

Sep 15, 2026

View reviewed changes

mario-campos left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. I added a few suggestions that I think would help make the points more explicit and direct.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

.github/copilot-instructions.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

.github/copilot-instructions.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

.github/copilot-instructions.md

		## Review instructions

		- When wording review comments, be helpful and friendly. Assume that the PR author has written the code with the best of intentions. Word your comments constructively as suggestions for improvements. Do not word suggestions as commands.
		- If you want to comment on a change that you believe will fail a CI check, do not present the CI failure you expect as a fact. Instead, write that you think a change "may" lead to a failure in CI. Suggest that, if such a failure manifests, the changes you are commenting on may be the place responsible for the failure and are worth looking at.

mario-campos Sep 15, 2026

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	- If you want to comment on a change that you believe will fail a CI check, do not present the CI failure you expect as a fact. Instead, write that you think a change "may" lead to a failure in CI. Suggest that, if such a failure manifests, the changes you are commenting on may be the place responsible for the failure and are worth looking at.
	- If you want to comment on a change that you believe will fail a CI check, you may state that, but do not make any definitive unsubstantiated statements about CI pass/fail. Instead, write that you think a change "may" lead to a failure in CI. Suggest that, if such a failure manifests, the changes you are commenting on may be the place responsible for the failure and are worth looking at.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

mbg Sep 16, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly seems like a more verbose version of what I wrote. Did you have a particular concern about the existing wording that you wanted to address here?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

.github/copilot-instructions.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

.github/copilot-instructions.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

mbg added 2 commits

September 16, 2026 11:14


          Merge remote-tracking branch 'origin/main' into mbg/copilot/update-in…

f959bfd

…structions


          Address review comments

53e5014

mbg commented Sep 16, 2026

Copy link

Copy Markdown

Member Author

@mario-campos Thanks for the review! I have pushed a commit which I hope addresses your comments. I have skipped some of the word changes and tried to avoid more duplication.

In general though, I think it makes sense to merge the changes without too much discussion about the wording of the instructions. We can see what does or doesn't work in practice once the changes are merged, and then address issues if we notice persistent problems.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mbg requested a review from mario-campos

September 16, 2026 10:32

mario-campos approved these changes

Sep 16, 2026

View reviewed changes

mbg added this pull request to the merge queue

Sep 16, 2026

Merged via the queue into main with commit 7dbd038

Sep 16, 2026

222 checks passed

Uh oh!

There was an error while loading. Please reload this page.

mbg deleted the mbg/copilot/update-instructions branch

September 16, 2026 13:16

This was referenced Sep 18, 2026

Merge main into releases/v4 #4152

Merged

Merge releases/v4 into releases/v3 #4154

Merged

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

mario-campos

mario-campos approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/XS

Should be very easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.