GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Address per-language bundle review follow-ups by henrymercer · Pull Request #4159 · github/codeql-action

Conversation

@henrymercer

@henrymercer henrymercer commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Address the remaining review feedback from #4146: stub nightly release listing directly, remove redundant test state, and clarify the timing and nightly eligibility comments. No production behavior changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
henrymercer and others added 4 commits September 22, 2026 16:07
@henrymercer
Use default state in per-language bundle tests
07dc949 
Co-authored-by: Copilot App <[email protected]>
@henrymercer
Stub nightly release listing directly
06344e2 
Co-authored-by: Copilot App <[email protected]>
@henrymercer
Clarify elapsed-time helper documentation
dba87a1 
Co-authored-by: Copilot App <[email protected]>
@henrymercer
Explain the nightly bundle version-check exception
a9a8cd1 
Co-authored-by: Copilot App <[email protected]>
@github-actions github-actions Bot added the size/S Should be easy to review label Sep 22, 2026
@henrymercer
henrymercer requested a balanced review from Copilot September 22, 2026 15:19
Copilot started reviewing on behalf of henrymercer September 22, 2026 15:20
View session
Copilot AI reviewed Sep 22, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The changes are behavior-neutral, with only a non-blocking wording issue noted.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
  • Low severity Clarify eligibility comment to cover forced nightly selection · New
What changed in this PR

Refines tests and comments following the per-language bundle work, without changing production behavior.

Changes:

  • Stubs nightly release listing directly through Octokit.
  • Removes redundant test state.
  • Clarifies timing and nightly eligibility comments.
File Description
src/​util.ts Clarifies elapsed-time documentation.
src/​setup-codeql.test.ts Directly stubs nightly release listing.
src/​per-language-bundles.ts Documents nightly version-check behavior.
src/​per-language-bundles.test.ts Removes redundant test setup.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/per-language-bundles.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@henrymercer
Tweak comment for latest nightly version check
f2ec2f6 
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
@henrymercer
henrymercer marked this pull request as ready for review September 22, 2026 15:24
@henrymercer
henrymercer requested a review from a team as a code owner September 22, 2026 15:24
mbg
mbg reviewed Sep 22, 2026
View reviewed changes
Comment thread src/per-language-bundles.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
henrymercer and others added 3 commits September 22, 2026 16:49
@henrymercer @mbg
Update src/per-language-bundles.ts
48321b2 
Co-authored-by: Michael B. Gale <[email protected]>
@henrymercer
Merge main into per-language bundle follow-ups
e574ef1 
Co-authored-by: Copilot App <[email protected]>
@henrymercer
Remove trailing whitespace from nightly comment
3bacfe2 
Co-authored-by: Copilot App <[email protected]>
@henrymercer
henrymercer requested a review from mbg September 22, 2026 16:43
mbg
mbg approved these changes Sep 22, 2026
View reviewed changes
@henrymercer
henrymercer added this pull request to the merge queue Sep 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 22, 2026

Uh oh!

There was an error while loading. Please reload this page.
@henrymercer
henrymercer added this pull request to the merge queue Sep 22, 2026
Merged via the queue into main with commit 33141e5 Sep 22, 2026
233 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@henrymercer
henrymercer deleted the henrymercer/pr-4146-follow-ups branch September 22, 2026 17:36
This was referenced Sep 23, 2026
Merge main into releases/v4 #4164
Closed
Merge main into releases/v4 #4168
Merged
Merge releases/v4 into releases/v3 #4171
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mbg mbg mbg approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/S Should be easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@henrymercer @mbg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.