GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Check `package-lock.json` for wrong addresses by mbg · Pull Request #4192 · github/codeql-action

Conversation

@mbg

@mbg mbg commented Oct 2, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR adds a check to make sure that certain URLs that would create issues for some contributors don't end up in package-lock.json.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Dashboards - I will watch relevant dashboards for issues after the release. Consider whether this requires this change to be released at a particular time rather than as part of a regular release.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mbg
mbg requested a review from henrymercer October 2, 2026 15:51
@mbg mbg self-assigned this Oct 2, 2026
Copilot AI balanced review requested due to automatic review settings October 2, 2026 15:51
@mbg
mbg requested a review from a team as a code owner October 2, 2026 15:51
@github-actions github-actions Bot added the size/XS Should be very easy to review label Oct 2, 2026
Copilot started reviewing on behalf of mbg October 2, 2026 15:52
View session
henrymercer
henrymercer previously approved these changes Oct 2, 2026
View reviewed changes

@henrymercer henrymercer left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also set min-release-age=7 in .npmrc and remove the @actions/* and actions/* Dependabot cooldown exclusions. This can happen in a separate PR though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Copilot AI reviewed Oct 2, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The configuration and validation check correctly implement the stated portability safeguard without affecting production workflows.

Review effort: Balanced
Findings: None

What changed in this PR

Makes npm lockfiles registry-agnostic and prevents internal feed URLs from being committed.

Changes:

  • Omits registry-resolved URLs from generated lockfiles.
  • Adds a PR check rejecting known internal package-feed URLs.
File Description
.npmrc Enables registry-agnostic lockfile generation.
.github/​workflows/​pr-checks.yml Detects internal feed URLs in package-lock.json.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mbg

This comment was marked as outdated.

Sign in to view
@mbg
mbg dismissed henrymercer’s stale review via 9008fdb October 2, 2026 16:19
@mbg
mbg force-pushed the mbg/project-changes branch from 3136764 to 9008fdb Compare October 2, 2026 16:19
@mbg
mbg changed the base branch from main to mbg/dependency/downgrade-cache October 2, 2026 16:19
@mbg
mbg added this pull request to stack #4195 October 2, 2026 16:19
@mbg
mbg force-pushed the mbg/project-changes branch from 9008fdb to d4c9bc1 Compare October 2, 2026 16:22
Base automatically changed from mbg/dependency/downgrade-cache to main October 2, 2026 16:43
@mbg
mbg force-pushed the mbg/project-changes branch 2 times, most recently from 579cce1 to d735805 Compare October 2, 2026 16:49
@mbg mbg changed the title Adjust feed-related configuration Check package-lock.json for wrong addresses Oct 2, 2026
@mbg
mbg requested a review from henrymercer October 2, 2026 16:50
@mbg
mbg force-pushed the mbg/project-changes branch from 3c10114 to ae091ae Compare October 2, 2026 16:56
@github-actions github-actions Bot added size/S Should be easy to review and removed size/XS Should be very easy to review labels Oct 2, 2026
mbg added 2 commits October 2, 2026 18:31
@mbg
Add check for non-public feed URLs
62b0dd9
@mbg
Install newer npm in Node 20 workflows
8948426
@mbg
mbg force-pushed the mbg/project-changes branch from ee7b65a to 8948426 Compare October 2, 2026 17:32
@github-actions github-actions Bot added size/XS Should be very easy to review and removed size/S Should be easy to review labels Oct 2, 2026
@mbg
Normalise feed URLs in package-lock.json
b948c4d
@mbg
mbg force-pushed the mbg/project-changes branch from 0f62d21 to b948c4d Compare October 2, 2026 17:38
henrymercer
henrymercer approved these changes Oct 2, 2026
View reviewed changes
@mbg
mbg added this pull request to the merge queue Oct 2, 2026
Merged via the queue into main with commit b6d38e5 Oct 2, 2026
233 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@mbg
mbg deleted the mbg/project-changes branch October 2, 2026 18:02
This was referenced Oct 8, 2026
Merge main into releases/v4 #4214
Merged
Merge releases/v4 into releases/v3 #4216
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@henrymercer henrymercer henrymercer approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mbg mbg

Labels

size/XS Should be very easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mbg @henrymercer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.