GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Minor VSCode workspace settings changes by mbg · Pull Request #4197 · github/codeql-action

Conversation

@mbg

@mbg mbg commented Oct 5, 2026

Copy link
Copy Markdown
Member

Two small changes:

  • One of the existing keys is deprecated. It is replaced with the new replacement key.
  • Added the "tests" folder to the excluded paths. This contains a number of language-specific integration tests. The reason for excluding it from the workspace by default is because some language-specific VSCode extensions will detect files in that directory and start up automatically even if none of the files are opened. That adds start-up time, runs unnecessary background processes, and some of the extensions complain rather loudly that the test projects don't meet their expectations. Unfortunately, there's no way to disable the extensions (if installed) for the workspace in a configuration file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
mbg added 2 commits October 5, 2026 11:08
@mbg
Replace deprecated config key
fa90489
@mbg
Exclude "tests" folder from workspace
363d874
@mbg
mbg requested a review from a team as a code owner October 5, 2026 10:20
Copilot AI balanced review requested due to automatic review settings October 5, 2026 10:20
@github-actions github-actions Bot added the size/XS Should be very easy to review label Oct 5, 2026
Copilot started reviewing on behalf of mbg October 5, 2026 10:21
View session
Copilot AI reviewed Oct 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The settings changes are valid and focused, with only a non-blocking wording correction noted.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
  • Low severity Correct product name capitalization to VS Code · New
What changed in this PR

Updates workspace defaults to reduce unnecessary extension activation and use the current VS Code TypeScript SDK setting.

Changes:

  • Excludes integration-test fixtures from the workspace.
  • Replaces the deprecated TypeScript SDK key.
File Description
.vscode/​settings.json Updates workspace exclusions and TypeScript SDK configuration.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread .vscode/settings.json
"build": true,
"lib": true,

// exclude "tests" by default because it causes VSCode to start language-specific extensions
henrymercer
henrymercer approved these changes Oct 5, 2026
View reviewed changes
@mbg
mbg enabled auto-merge October 5, 2026 10:27
@mbg
mbg added this pull request to the merge queue Oct 5, 2026
Merged via the queue into main with commit aeafd00 Oct 5, 2026
234 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@mbg
mbg deleted the mbg/vscode/workspace-improvements branch October 5, 2026 10:44
This was referenced Oct 8, 2026
Merge main into releases/v4 #4214
Merged
Merge releases/v4 into releases/v3 #4216
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@henrymercer henrymercer henrymercer approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/XS Should be very easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mbg @henrymercer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.