GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Do not validate change-note file names or frontmatter by mario-campos · Pull Request #4218 · github/codeql-action

Conversation

@mario-campos

@mario-campos mario-campos commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

While reviewing #4211, @mbg noted that the strict validation is unnecessary. Nothing about the Action relies on the change-note file names to be a certain format. And the category in the frontmatter is validated, but never used.

This PR effectively disables those checks from pr-checks/changenotes.ts validate while keeping the core of the code until we can decide to either completely remove it or apply it.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • N/A

Products:

  • N/A

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • N/A

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mario-campos
Do not validate change-note file names or frontmatter
1ced68e
Presently, the strict filename or frontmatter are not being used; so we're validating them unnecessarily. So, for now, remove these checks until we decide to either do something with them, or delete the code entirely.
@mario-campos
mario-campos requested a review from a team as a code owner October 8, 2026 20:15
@mario-campos
mario-campos requested review from mbg and a balanced review from Copilot October 8, 2026 20:15
@github-actions github-actions Bot added the size/S Should be easy to review label Oct 8, 2026
Copilot started reviewing on behalf of mario-campos October 8, 2026 20:16
View session
@mario-campos mario-campos mentioned this pull request Oct 8, 2026
Document change-notes process #4211
Merged
Copilot AI reviewed Oct 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Regression tests are needed to verify that unconventional filenames and frontmatter are accepted.

1 open finding
  • Medium severity Add tests for relaxed changenote filename and frontmatter validation · New
What changed in this PR

Disables filename and frontmatter-category checks while retaining Markdown content validation.

Changes:

  • Removes filename and category validation from file-level checks.
  • Removes tests expecting those checks to fail.
File Description
pr-checks/​changelog/​validate.ts Limits validation to Markdown content.
pr-checks/​changelog/​validate.test.ts Removes outdated rejection tests.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread pr-checks/changelog/validate.test.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

mbg
mbg previously approved these changes Oct 9, 2026
View reviewed changes

@mbg mbg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I'd ignore Copilot's request for tests. This doesn't need any.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread pr-checks/changelog/validate.test.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos
Delete unused path import
45cda5b
@mario-campos
mario-campos dismissed mbg’s stale review via 45cda5b October 9, 2026 13:57
@mario-campos
mario-campos requested a review from mbg October 9, 2026 13:57
mbg
mbg approved these changes Oct 9, 2026
View reviewed changes
@mario-campos
mario-campos added this pull request to the merge queue Oct 9, 2026
Merged via the queue into main with commit 5532d8e Oct 9, 2026
234 of 240 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@mario-campos
mario-campos deleted the mario-campos/loosen-changenote-validation branch October 9, 2026 17:57
This was referenced Oct 14, 2026
Merge main into releases/v4 dsp-testing/mario-campos-post-comment-test#6
Merged
Merge main into releases/v4 #4239
Merged
Merge releases/v4 into releases/v3 #4241
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mbg mbg mbg approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/S Should be easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mario-campos @mbg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.