GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable cleaning up toolcache bundles by default by henrymercer · Pull Request #4242 · github/codeql-action

Conversation

@henrymercer

@henrymercer henrymercer commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

This PR graduates the cleanup_toolcache_bundles feature flag and removes the CODEQL_ACTION_CLEANUP_TOOLCACHE_BUNDLES override.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
  • Code Quality - The changes impact analyses when analysis-kinds: code-quality.
  • Other first-party - The changes impact other first-party analyses.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - The existing codeql-action/toolcache-bundle-cleanup diagnostic reports deleted versions and whether cleanup failed.
  • Other - Cleanup failures remain visible in action logs and do not prevent the bundle download from continuing.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows. The removed environment variable was an internal rollout override rather than a documented workflow interface.
  • Consider adding a changelog entry for this change. The 4.38.0 entry already describes the staged rollout, so no additional entry is included.
  • Confirm the readme and docs have been updated if necessary. No documentation updates are required.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
henrymercer and others added 2 commits October 15, 2026 14:54
@henrymercer
Enable toolcache bundle cleanup by default
1ec6b03 
Co-authored-by: Copilot App <[email protected]>
Copilot-Session: 9bf883d4-ecd7-4428-970f-86895f760571
@henrymercer
Remove the toolcache cleanup test override
4ebc48b 
Co-authored-by: Copilot App <[email protected]>
Copilot-Session: 9bf883d4-ecd7-4428-970f-86895f760571
Copilot AI max review requested due to automatic review settings October 15, 2026 19:44
@github-actions github-actions Bot added the size/S Should be easy to review label Oct 15, 2026
Copilot started reviewing on behalf of henrymercer October 15, 2026 19:45
View session
Copilot AI reviewed Oct 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

🔵 Needs a closer look

Removing the cleanup disable switch warrants human confirmation of rollout telemetry.

0 open findings

What changed in this PR

Makes CodeQL toolcache cleanup the default on eligible GitHub-hosted runners to reclaim disk space for analysis.

Changes:

  • Removes the cleanup feature flag and environment override while retaining existing safeguards.
  • Updates tests and the multi-language autodetection check template for the new default.
File Description
src/​setup-codeql.ts Removes feature gating from bundle cleanup.
src/​setup-codeql.test.ts Updates cleanup tests and injected environments.
src/​feature-flags.ts Removes the cleanup flag and override configuration.
pr-checks/​checks/​multi-language-autodetect.yml Removes the obsolete cleanup override.
Files excluded by content exclusion policy (2)
  • .github/workflows/__multi-language-autodetect.yml
  • lib/entry-points.js

🧠 Review effort: Max

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@henrymercer
henrymercer marked this pull request as ready for review October 15, 2026 20:02
@henrymercer
henrymercer requested a review from a team as a code owner October 15, 2026 20:02
mbg
mbg approved these changes Oct 16, 2026
View reviewed changes
@henrymercer
henrymercer added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit ae098fa Oct 16, 2026
235 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@henrymercer
henrymercer deleted the henrymercer/graduate-toolcache-cleanup branch October 16, 2026 12:55
This was referenced Oct 21, 2026
Merge main into releases/v4 #4257
Merged
Merge releases/v4 into releases/v3 #4259
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mbg mbg mbg approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/S Should be easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@henrymercer @mbg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.