GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Graduate overlay-aware CodeQL version selection by henrymercer · Pull Request #4246 · github/codeql-action

Conversation

@henrymercer

@henrymercer henrymercer commented Oct 16, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Graduate overlay_analysis_match_codeql_version and remove the overlay_analysis_match_codeql_version_dry_run dry run, along with the telemetry diagnostic added for it. Also, as a small optimisation, skip listing the Actions cache when only one default CodeQL version is enabled, since there is only one CodeQL version to choose in this case. This includes GHES, since there are no feature flags and therefore only one CodeQL version will ever be enabled there.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • Advanced setup - Impacts users who have custom CodeQL workflows.
  • Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

  • Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.

Environments:

  • Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
henrymercer and others added 2 commits October 16, 2026 14:01
@henrymercer
Remove overlay version matching dry run
0e72543
Co-authored-by: Copilot App <[email protected]>
@henrymercer
Use overlay-aware CodeQL versions by default
6d82d4f
Co-authored-by: Copilot App <[email protected]>
Copilot AI max review requested due to automatic review settings October 16, 2026 13:21
@github-actions github-actions Bot added the size/L May be hard to review label Oct 16, 2026
Copilot started reviewing on behalf of henrymercer October 16, 2026 13:22
View session
Copilot AI reviewed Oct 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

🔵 Needs a closer look

A maintainer should confirm rollout readiness before removing the feature-flag kill switch.

1 open finding
  • Low severity Remove redundant empty-list guard · New
What changed in this PR

Graduates overlay-aware default CodeQL version selection for eligible Code Scanning pull requests.

Changes:

  • Removes feature flags, dry-run behavior, and diagnostic telemetry.
  • Skips cache lookup on GHES and when only one default version is enabled.
  • Updates regression coverage for selection eligibility.
File Description
src/​setup-codeql.ts Graduates selection and adds cache-lookup guards.
src/​setup-codeql.test.ts Covers supported environments and bypass conditions.
src/​feature-flags.ts Removes selection and dry-run flags.
Files excluded by content exclusion policy (1)
  • lib/entry-points.js

🧠 Review effort: Max


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/setup-codeql.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@henrymercer
Remove redundant empty-list check
9127084
Co-authored-by: Copilot App <[email protected]>
@henrymercer
henrymercer marked this pull request as ready for review October 16, 2026 14:08
@henrymercer
henrymercer requested a review from a team as a code owner October 16, 2026 14:08
@henrymercer
Merge remote-tracking branch 'origin/main' into henrymercer/graduate-…
961c840
…overlay-version-match

Co-authored-by: Copilot App <[email protected]>
mbg
mbg previously approved these changes Oct 21, 2026
View reviewed changes

@mbg mbg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense and thanks for the explanation of the drive-by improvement in the PR description. Just one minor comment about the rather large condition in getEnabledVersionsWithOverlayBaseDatabases.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/setup-codeql.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@henrymercer
Simplify the condition for overlay-aware version selection
54af742
Co-authored-by: Copilot App <[email protected]>
@henrymercer
henrymercer dismissed mbg’s stale review via 54af742 October 22, 2026 10:25
mbg
mbg previously approved these changes Oct 22, 2026
View reviewed changes

@mbg mbg left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying / documenting that!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@henrymercer
Merge remote-tracking branch 'origin/main' into henrymercer/graduate-…
6aa7e65
…overlay-version-match

Co-authored-by: Copilot App <[email protected]>
@henrymercer
henrymercer dismissed mbg’s stale review via 6aa7e65 October 22, 2026 11:42
@henrymercer
henrymercer requested a review from mbg October 22, 2026 12:47
mbg
mbg approved these changes Oct 22, 2026
View reviewed changes
@henrymercer
henrymercer added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit bdadc03 Oct 22, 2026
228 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@henrymercer
henrymercer deleted the henrymercer/graduate-overlay-version-match branch October 22, 2026 13:08
This was referenced Nov 3, 2026
Merge main into releases/v4 #4286
Merged
Merge releases/v4 into releases/v3 #4291
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mbg mbg mbg approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/L May be hard to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@henrymercer @mbg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.