GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add Copilot instructions for FFs, and update documentation more generally by mbg · Pull Request #4247 · github/codeql-action

Conversation

@mbg

@mbg mbg commented Oct 16, 2026

Copy link
Copy Markdown
Member

Prompted by #4244 (comment). I added a few other improvements based on recent experiences as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mbg added 3 commits October 16, 2026 15:11
@mbg
Update copilot-instructions.md to mention feature flags
0d2baf6
@mbg
Update "Review instructions" based on recent reviews
2441e6e
@mbg
Add some guidelines for change notes
f3c93e3
@mbg
mbg requested a review from a team as a code owner October 16, 2026 14:34
Copilot AI max review requested due to automatic review settings October 16, 2026 14:34
@github-actions github-actions Bot added the size/XS Should be very easy to review label Oct 16, 2026
Copilot started reviewing on behalf of mbg October 16, 2026 14:34
View session
Copilot AI reviewed Oct 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Remaining suggestions concern non-blocking documentation clarity and wording.

2 open findings
  • Low severity Align request prohibition with suggested examples · New
  • Low severity Qualify exemption for features enabled by default everywhere · New
What changed in this PR

Clarifies CodeQL Action guidance for review feedback and release notes.

Changes:

  • Expands guidance on review priorities and constructive wording.
  • Documents change-note expectations for feature flags and workflow-impacting changes.
File Description
unreleased-change-notes/​README.md Adds guidance on which changes need release notes.
.github/​copilot-instructions.md Expands review guidance and adds feature-flag documentation rules.

🧠 Review effort: Max

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/copilot-instructions.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/copilot-instructions.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
henrymercer
henrymercer previously approved these changes Oct 16, 2026
View reviewed changes
Comment thread .github/copilot-instructions.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mbg added 3 commits October 16, 2026 16:02
@mbg
Elaborate GHES details
6992155
@mbg
Drop "requests" again
e461913
@mbg
Suggest "Minor" prefix
5ecf3b3
@mbg
mbg dismissed henrymercer’s stale review via 5ecf3b3 October 16, 2026 15:03
@mbg
mbg requested a review from henrymercer October 16, 2026 15:04
henrymercer
henrymercer approved these changes Oct 16, 2026
View reviewed changes
@mbg
mbg added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit 83e1837 Oct 16, 2026
234 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@mbg
mbg deleted the mbg/copilot/clarify-feature-flags branch October 16, 2026 15:33
This was referenced Oct 21, 2026
Merge main into releases/v4 #4257
Merged
Merge releases/v4 into releases/v3 #4259
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@henrymercer henrymercer henrymercer approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/XS Should be very easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mbg @henrymercer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.