GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Move inline script from `diagnostics-export.yml` to a `.ts` file by mbg · Pull Request #4248 · github/codeql-action

Conversation

@mbg

@mbg mbg commented Oct 16, 2026

Copy link
Copy Markdown
Member

A simple dev-only change in prep for #4223 which moves the inline script out of the diagnostics-export.yml workflow and into a TS file, along with some minor changes to make TS happy.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mbg
Move inline script from diagnostics-export.yml to a .ts file
604377f
@mbg
mbg requested a review from henrymercer October 16, 2026 15:54
@mbg
mbg requested a review from a team as a code owner October 16, 2026 15:54
Copilot AI max review requested due to automatic review settings October 16, 2026 15:54
@github-actions github-actions Bot added the size/M Should be of average difficulty to review label Oct 16, 2026
Copilot started reviewing on behalf of mbg October 16, 2026 15:55
View session
Copilot AI reviewed Oct 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.

🟢 Approval recommended

The development-only extraction preserves existing checks and has no blocking issues.

0 open findings

What changed in this PR

Extracts the diagnostics-export workflow’s inline checks into TypeScript, preparing the development-only test for #4223.

Changes:

  • Moves existing SARIF assertions into a standalone script with explicit missing-field checks.
  • Enables Node setup and runs the script with tsx.
File Description
pr-checks/​checks/​diagnostics-export.yml Replaces the inline script with TypeScript execution.
pr-checks/​check-diagnostics.ts Contains the extracted diagnostic assertions.
Files excluded by content exclusion policy (1)
  • .github/workflows/__diagnostics-export.yml

🧠 Review effort: Max

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mbg
mbg added this pull request to stack #4250 October 16, 2026 16:13
henrymercer
henrymercer approved these changes Oct 20, 2026
View reviewed changes
Comment thread pr-checks/check-diagnostics.ts

@henrymercer henrymercer Oct 20, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this lives separately from the check, we could add a brief description of what this script does in a header docstring.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mbg reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@mbg mbg Oct 20, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, will do as a follow-up somewhere else.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mbg
mbg added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit 0fda7a6 Oct 20, 2026
236 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@mbg
mbg deleted the mbg/move-diag-export-script branch October 20, 2026 16:07
This was referenced Oct 21, 2026
Merge main into releases/v4 #4257
Merged
Merge releases/v4 into releases/v3 #4259
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@henrymercer henrymercer henrymercer approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/M Should be of average difficulty to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mbg @henrymercer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.