GeezerVison

extractTarZst ran tar by name. On Windows, child_process.spawn by default looks for a bare command name in the current directory before searching PATH, so this could run a different tar from the one that getTarVersion checked. In practice, this only affects Windows runners with a tools input that points to a .tar.zst bundle, since the Action otherwise uses gzip bundles on Windows.

This PR records the path that getTarVersion resolves with io.which, which only searches PATH, and runs that path. The [command] log line and error messages now show this resolved path. On Linux and macOS, where zstd bundles are the default, this should otherwise run the same tar as before.

It also fixes stdout and stderr being passed to CommandInvocationError the wrong way round, so when tar exits with an error, the error message now includes the last line of tar's stderr rather than its stdout.

Risk assessment

For internal use only. Please select the risk level of this change:

• Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

• Advanced setup - Impacts users who have custom CodeQL workflows.
• Managed - Impacts users with dynamic workflows (Default Setup, Code Quality, ...).

Products:

• Code Scanning - The changes impact analyses when analysis-kinds: code-scanning.
• Code Quality - The changes impact analyses when analysis-kinds: code-quality.
• Other first-party - The changes impact other first-party analyses.
• Third-party analyses - The changes affect the upload-sarif action.

Environments:

• Dotcom - Impacts CodeQL workflows on github.com and/or GitHub Enterprise Cloud with Data Residency.
• GHES - Impacts CodeQL workflows on GitHub Enterprise Server.

How did/will you validate this change?

• End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).
• Other - I checked manually that when tar exits with an error, the error message includes the last line of tar's stderr.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

• Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

• Telemetry - I rely on existing telemetry or have made changes to the telemetry.

Are there any special considerations for merging or releasing this change?

• No special considerations - This change can be merged at any time.

Merge / deployment checklist

• Confirm this change is backwards compatible with existing workflows.
• Consider adding a changelog entry for this change.
• Confirm the readme and docs have been updated if necessary.