GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Migrate bundle update workflow to new changenote tooling by henrymercer · Pull Request #4285 · github/codeql-action

Conversation

@henrymercer

@henrymercer henrymercer commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

The "Update default CodeQL bundle" workflow currently adds its "Update default CodeQL bundle version" entry directly to the [UNRELEASED] section of CHANGELOG.md. This PR changes pr-checks/bundle-changelog.ts to write the entry to a changenote file in unreleased-change-notes/ instead, so that it's added to the changelog with the other changenotes when we release.

The workflow now stages the unreleased-change-notes directory, since git commit -a doesn't pick up new files.

With this change, bundle update PRs no longer modify CHANGELOG.md, so they won't need to be excluded from the check added in #4217.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Workflow types:

  • N/A

Products:

  • N/A

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • Other - I ran pr-checks/bundle-changelog.ts locally and checked that npx tsx pr-checks/changenotes.ts validate accepts the generated note and that npx tsx pr-checks/changenotes.ts assemble adds it to the [UNRELEASED] section of CHANGELOG.md. The workflow only runs when a CodeQL bundle prerelease is published, so the next bundle update will be its first run.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other - The "Update default CodeQL bundle" workflow run would fail, or the bundle update PR would be missing its changenote.

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
henrymercer and others added 2 commits November 2, 2026 17:40
@henrymercer
Create a changenote for bundle updates instead of editing the changelog
9bc74b1
Co-authored-by: Copilot App <[email protected]>
@henrymercer
Remove unused updateChangelog from bundle-changelog.ts
3952845
Co-authored-by: Copilot App <[email protected]>
Copilot AI auto review requested due to automatic review settings November 2, 2026 17:50
Copilot started reviewing on behalf of henrymercer November 2, 2026 17:50
View session
@github-actions github-actions Bot added the size/M Should be of average difficulty to review label Nov 2, 2026
Copilot AI reviewed Nov 2, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the migration of bundle-update release notes to the changenote pipeline.

No open issues 🎉

What changed in this PR

Moves bundle-update release notes into the existing changenote pipeline, so bundle update PRs no longer modify CHANGELOG.md directly or need an exception to the check proposed in #4217.

Changes:

  • Creates version-specific changenote files with links to the bundle release and update PR.
  • Replaces changelog-editing tests with checks for changenote content and validity.
  • Explicitly stages new changenote files before committing and pushing.
File Description
pr-checks/​bundle-changelog.ts Writes a bundle-update changenote instead of editing the changelog.
pr-checks/​bundle-changelog.test.ts Tests generated note contents and compatibility with changenote validation.
.github/​workflows/​update-bundle.yml Stages and commits the new changenote files.

Review effort: Balanced (auto)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@henrymercer
henrymercer marked this pull request as ready for review November 2, 2026 17:51
@henrymercer
henrymercer requested a review from a team as a code owner November 2, 2026 17:51
@henrymercer
henrymercer requested a review from mario-campos November 2, 2026 17:52
mbg
mbg approved these changes Nov 3, 2026
View reviewed changes
@henrymercer
henrymercer added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 0d5ac7a Nov 3, 2026
231 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@henrymercer
henrymercer deleted the henrymercer/automated-change-notes branch November 3, 2026 10:26
This was referenced Nov 4, 2026
Merge main into releases/v4 #4299
Merged
Merge releases/v4 into releases/v3 #4304
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mbg mbg mbg approved these changes
@mario-campos mario-campos Awaiting requested review from mario-campos

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/M Should be of average difficulty to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@henrymercer @mbg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.