GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Warn about direct CHANGELOG.md changes in PR checks by mario-campos · Pull Request #4294 · github/codeql-action

Conversation

@mario-campos

@mario-campos mario-campos commented Nov 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR adds a PR check for non-release/mergeback/update-bundle PRs. The check posts a sticky PR comment if CHANGELOG.md has been modified in the PR, warning the author to instead direct their change to a change-note.

This PR is split-off from #4217, which retains the prerequisite post-comment Action.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Repository development/CI only

Which use cases does this change impact?

  • Workflow types: None of the production workflow types; only this repository's PR checks.

  • Products: No production analysis behavior changes.

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • End-to-end tests - PR checks provide eventual integration coverage after Add post-comment Action #4217 merges and this PR is updated.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other - Observe the PR Checks job logs and warning/resolution comments after the prerequisite merges and this PR is updated.

Are there any special considerations for merging or releasing this change?

  • Special considerations - As this PR depends on an Action introduced in Add post-comment Action #4217 being in main, Add post-comment Action #4217 must merge first. CI is expected to fail until then. After Add post-comment Action #4217 is merged, then this PR will be rebased.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows. Existing repo-size commenting is preserved; the new local action requires Add post-comment Action #4217 on main first.
  • Consider adding a changelog entry for this change. Not needed for repository-only CI activation.
  • Confirm the readme and docs have been updated if necessary. No production documentation changes are needed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mario-campos
mario-campos requested a review from a team as a code owner November 3, 2026 17:16
Copilot AI auto review requested due to automatic review settings November 3, 2026 17:16
Copilot started reviewing on behalf of mario-campos November 3, 2026 17:16
View session
@github-actions github-actions Bot added the size/S Should be easy to review label Nov 3, 2026
Copilot AI reviewed Nov 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The workspace-only install omits required root dependencies, leaving warning and resolution comment scripts at risk of module-loading failures in CI.

1 open issue
  • High severity Install root dependencies for the comment script in CI · New
What changed in this PR

Activates warnings for direct CHANGELOG.md edits in repository PR checks, using the comment action supplied by prerequisite #4217. Production CodeQL workflows are unaffected.

Changes:

  • Detects changelog modifications and exposes the result as a job output.
  • Extends the commenting job with trusted main checkout and Node/dependency setup.
  • Adds sticky warning and update-only resolution comments, excluding release, backport, mergeback, and bundle-update branches.
File Description
.github/​workflows/​pr-checks.yml Wires changelog detection and warning/resolution comments into PR checks while preserving repo-size commenting.

Review effort: Balanced (auto)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/pr-checks.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mario-campos mario-campos mentioned this pull request Nov 3, 2026
Add post-comment Action #4217
Merged
@mario-campos
mario-campos requested a review from mbg November 3, 2026 17:46
mario-campos and others added 2 commits November 11, 2026 00:23
@mario-campos
Warn about direct CHANGELOG.md changes in PR checks
f039c78 
Split workflow activation from #4217 while keeping the comment action loaded from trusted main.

Co-authored-by: Copilot App <[email protected]>
@mario-campos
Install root dependencies for PR comment action
9e531e1 
Co-authored-by: Copilot App <[email protected]>
@mario-campos
mario-campos force-pushed the mario-campos-changelog-workflow-activation branch from 5c6d084 to 9e531e1 Compare November 11, 2026 06:24

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mbg mbg Awaiting requested review from mbg

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/S Should be easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mario-campos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.