GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Dispatch fingerprint callbacks only to matching source lines by dsyme · Pull Request #4295 · github/codeql-action

Conversation

dsyme commented Nov 3, 2026

Copy link

Copy Markdown

Summary

Index fingerprint callbacks by source line within each file instead of invoking every result callback for every emitted line hash. Files are still hashed once and the rolling hash and fingerprint format are unchanged.

This removes the lines-times-results callback dispatch cost on files with many findings, including the repeated Object.values array creation. Multiple results on the same line still receive the same fingerprint; inconsistent existing fingerprints are preserved and still generate warnings.

Validation

Add an upstream regression fixture covering duplicate line locations, different lines, out-of-range locations, and inconsistent existing fingerprints.
npm run ava -- src/fingerprints.test.ts: 5 tests passed, including existing golden SARIF/hash fixtures.
ESLint on changed TypeScript passed.
npm run build: typecheck and bundle generation passed; regenerated lib/entry-points.js is included.
Change-note validation passed.

Validated locally with Node 24.22.2. This PR makes no whole-analysis or fleet savings claim.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Dispatch fingerprint callbacks only to matching source lines

4c50d85

Co-authored-by: Copilot <[email protected]>

Copilot AI auto review requested due to automatic review settings

November 3, 2026 18:38

dsyme requested a review from a team as a code owner

November 3, 2026 18:38

Copilot started reviewing on behalf of dsyme

November 3, 2026 18:39

View session

Copilot AI reviewed

Nov 3, 2026

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block approval of the SARIF fingerprint dispatch optimization.

No open issues 🎉

1 file not reviewed

lib/entry-points.js: Excluded by your content exclusion settings

What changed in this PR

Optimizes SARIF fingerprint generation by dispatching each source-line hash only to matching results, while preserving the existing hash algorithm and fingerprint behavior.

Changes:

Indexes callbacks by line within each file, avoiding per-line iteration over every result.
Adds regression coverage for duplicate locations, different lines, out-of-range locations, and preservation of inconsistent existing fingerprints with warnings.
Adds a changenote describing the performance improvement.

File	Description
`unreleased-change-notes/fingerprint-callback-dispatch.md`	Documents faster fingerprint generation without changing fingerprints.
`src/fingerprints.ts`	Groups callbacks by source line for targeted dispatch.
`src/fingerprints.test.ts`	Tests matching-line dispatch and preserved edge-case behavior.

_{Review effort: Balanced (auto)}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

This branch has not been deployed

No deployments

Reviewers

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.