GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Refactor/clean-up diff-informed utils by mbg · Pull Request #4300 · github/codeql-action

Conversation

@mbg

@mbg mbg commented Nov 4, 2026

Copy link
Copy Markdown
Member

This PR refactors diff-informed analysis utilities into a new diff-informed subfolder, improves the JSDocs for the functions, and makes the file path an explicit argument rather than implicitly computed value based on an environment variable so that tests don't have to rely on global state manipulation going forward.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mbg added 4 commits November 4, 2026 13:24
@mbg
Move diff-informed utils to subfolder
2465f77
@mbg
Improve JSDocs in diff-informed/index.ts
3a4f195
@mbg
Make jsonFilePath an explicit input to functions in `diff-informed/…
8c16574 
…index.ts`
@mbg
Move getDiffRangesJsonFilePath to diff-informed/index.ts
c29d405
@mbg
mbg requested a review from a team as a code owner November 4, 2026 16:12
Copilot AI auto review requested due to automatic review settings November 4, 2026 16:12
@github-actions github-actions Bot added the size/M Should be of average difficulty to review label Nov 4, 2026
Copilot started reviewing on behalf of mbg November 4, 2026 16:13
View session
Copilot AI reviewed Nov 4, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The lockfile still resolves glob to 13.0.6 despite the workspace requiring ^14.0.3, leaving a dependency mismatch that may cause npm ci to fail.

No open issues 🎉

What changed in this PR

This PR consolidates diff-informed analysis utilities into a dedicated module and makes persisted diff-range paths explicit, enabling tests to rely less on global environment state.

Changes:

  • Moves utilities into src/diff-informed and expands their JSDocs.
  • Updates callers and tests for explicit file-path arguments.
  • Refreshes the generated JavaScript bundle and updates the workspace’s glob requirement metadata.
File Description
src/​upload-lib.ts Passes an explicit path when reading diff ranges.
src/​upload-lib.test.ts Updates imports and stubs the path helper.
src/​overlay/​index.ts Uses the relocated path helper.
src/​overlay/​index.test.ts Updates path-helper stubs.
src/​diff-informed/​index.ts Consolidates utilities, adds path parameters, and improves JSDocs.
src/​diff-informed/​index.test.ts Relocates tests and updates function arguments.
src/​config-utils.ts Computes the diff-range path from action state.
src/​config-utils.test.ts Configures temporary paths through test environments.
src/​analyze.ts Uses the new module and explicit read path.
src/​actions-util.ts Removes the relocated path helper.
package-lock.json Updates workspace glob requirement metadata.
lib/​entry-points.js Generated bundle reflecting the TypeScript refactor.

Review effort: Balanced (auto)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Base automatically changed from mbg/decouple-features-enum to main November 4, 2026 16:29
@henrymercer
henrymercer requested a max review from Copilot November 5, 2026 15:32
Copilot started reviewing on behalf of henrymercer November 5, 2026 15:33
View session
Copilot AI reviewed Nov 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The test setup leaves hosted-runner detection dependent on the real CI environment, which can unexpectedly enable TRAP caching and break assertions expecting zero download time.

1 open issue
  • Medium severity Initialize hosted-runner environment in affected tests · New

Review effort: Max

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/config-utils.test.ts
const languages = "javascript,python";

setupActionsVars(tempDir, tempDir);
setupActionsVars(tempDir, tempDir, {}, state.env);
@mbg
Merge branch 'main' into mbg/clean-up-diff-informed-utils
49cca89

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

size/M Should be of average difficulty to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mbg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.