GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Still run `git for-each-ref` when explicit roots and reference filter… · github/git-sizer@721e353

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

git-sizer.go
git
- ref_filter.go
internal/refopts
- ref_group.go
- ref_group_builder.go

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎git-sizer.go‎`

Copy file name to clipboardExpand all lines: git-sizer.go

+13-6Lines changed: 13 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -307,26 +307,33 @@ func mainImplementation(ctx context.Context, stdout, stderr io.Writer, args []st`
`307`	`307`	`}`
`308`	`308`
`309`	`309`	`var roots []sizes.Root`
	`310`	`+ var explicitRoots []sizes.Root`
`310`	`311`	`// If arguments are provided, use them as explicit roots.`
`311`	`312`	`if len(flags.Args()) > 0 {`
`312`		`- roots = make([]sizes.Root, 0, len(flags.Args()))`
	`313`	`+ explicitRoots = make([]sizes.Root, 0, len(flags.Args()))`
`313`	`314`	`for _, arg := range flags.Args() {`
`314`	`315`	`oid, err := repo.ResolveObject(arg)`
`315`	`316`	`if err != nil {`
`316`	`317`	`return fmt.Errorf("resolving command-line argument %q: %w", arg, err)`
`317`	`318`	`}`
`318`		`- roots = append(roots, sizes.NewExplicitRoot(arg, oid))`
	`319`	`+ explicitRoots = append(explicitRoots, sizes.NewExplicitRoot(arg, oid))`
`319`	`320`	`}`
	`321`	`+ }`
	`322`	`+`
	`323`	`+ // If no reference filters and no explicit roots were provided`
	`324`	`+ if git.IsNoReferencesFilter(rgb.GetTopLevelGroup().GetFilter()) {`
	`325`	`+ roots = explicitRoots`
`320`	`326`	`} else {`
`321`		`- refs, err := sizes.CollectReferences(ctx, repo, rg)`
	`327`	`+ refRoots, err := sizes.CollectReferences(ctx, repo, rg)`
`322`	`328`	`if err != nil {`
`323`	`329`	`return fmt.Errorf("determining which reference to scan: %w", err)`
`324`	`330`	`}`
`325`	`331`
`326`		`- roots = make([]sizes.Root, 0, len(refs))`
`327`		`- for _, ref := range refs {`
`328`		`- roots = append(roots, ref)`
	`332`	`+ roots = make([]sizes.Root, 0, len(refRoots)+len(explicitRoots))`
	`333`	`+ for _, refRoot := range refRoots {`
	`334`	`+ roots = append(roots, refRoot)`
`329`	`335`	`}`
	`336`	`+ roots = append(roots, explicitRoots...)`
`330`	`337`	`}`
`331`	`338`
`332`	`339`	`historySize, err := sizes.ScanRepositoryUsingGraph(`

Collapse file

`‎git/ref_filter.go‎`

Copy file name to clipboardExpand all lines: git/ref_filter.go

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -140,3 +140,8 @@ type regexpFilter struct {`
`140`	`140`	`func (f regexpFilter) Filter(refname string) bool {`
`141`	`141`	`return f.re.MatchString(refname)`
`142`	`142`	`}`
	`143`	`+`
	`144`	`+func IsNoReferencesFilter(val interface{}) bool {`
	`145`	`+ _, ok := val.(noReferencesFilter)`
	`146`	`+ return ok`
	`147`	`+}`

Collapse file

`‎internal/refopts/ref_group.go‎`

Copy file name to clipboardExpand all lines: internal/refopts/ref_group.go

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,10 @@ type refGroup struct {`
`30`	`30`	`otherRefGroup *sizes.RefGroup`
`31`	`31`	`}`
`32`	`32`
	`33`	`+func (rg *refGroup) GetFilter() git.ReferenceFilter {`
	`34`	`+ return rg.filter`
	`35`	`+}`
	`36`	`+`
`33`	`37`	`func (rg *refGroup) collectSymbols(refname string) (bool, []sizes.RefGroupSymbol) {`
`34`	`38`	`walk := false`
`35`	`39`	`var symbols []sizes.RefGroupSymbol`

Collapse file

`‎internal/refopts/ref_group_builder.go‎`

Copy file name to clipboardExpand all lines: internal/refopts/ref_group_builder.go

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,10 @@ type RefGroupBuilder struct {`
`22`	`22`	`groups map[sizes.RefGroupSymbol]*refGroup`
`23`	`23`	`}`
`24`	`24`
	`25`	`+func (rgb RefGroupBuilder) GetTopLevelGroup() refGroup {`
	`26`	`+ return rgb.topLevelGroup`
	`27`	`+}`
	`28`	`+`
`25`	`29`	// NewRefGroupBuilder creates and returns a `RefGroupBuilder`
`26`	`30`	`// instance.`
`27`	`31`	`func NewRefGroupBuilder(configger Configger) (*RefGroupBuilder, error) {`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.