GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Enable contributions from Windows developers by ScottArbeit · Pull Request #139 · github/git-sizer

Conversation

ScottArbeit commented Apr 2, 2025

Copy link

Copy Markdown

This PR adds support for Windows developers to contribute to the project. It includes PowerShell-equivalent scripts the bash scripts that set up prerequisites and dependencies, as well as a Windows-specific Makefile that uses PowerShell to execute its steps.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Scott Arbeit added 2 commits

March 31, 2025 23:55


          Adding support for contributing using Windows.

5bbde89


          Updates to Makefile for Windows after testing

5e839b7

Copilot AI review requested due to automatic review settings

April 2, 2025 18:15

ScottArbeit requested a review from a team as a code owner

April 2, 2025 18:15

Copilot AI reviewed

Apr 2, 2025

View reviewed changes

Copilot AI left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables Windows developers to contribute to the project by updating the contribution guidelines.

Updated dependency installation instructions with platform-specific commands.
Added separate commands for running tests on Unix-like and Windows systems.

Files not reviewed (4)

Makefile.win: Language not supported
script/bootstrap.ps1: Language not supported
script/ensure-go-installed.ps1: Language not supported
script/go.ps1: Language not supported

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

CONTRIBUTING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update CONTRIBUTING.md

2b258ba

Co-authored-by: Copilot <[email protected]>

ScottArbeit commented Apr 2, 2025

Copy link

Copy Markdown

Author

cc: @ttaylorr

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mhagger reviewed

Apr 3, 2025

View reviewed changes

mhagger left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't vet the code, but I like the sentiment!

I left one comment, more out of curiosity than as an informed suggestion. BTW two of the new files are missing a trailing EOL on their last lines.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Makefile.win Outdated


		# Help target
		help:
		@powershell -NoProfile -ExecutionPolicy Bypass -Command "Write-Host 'Windows Makefile for git-sizer' -ForegroundColor Cyan"

mhagger Apr 3, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an easier way to make powershell be used for all commands rather than having to write them all out like this? Glancing at the GNU make docs, maybe setting MAKESHELL would do something like that?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ScottArbeit Apr 7, 2025

Copy link

Copy Markdown

Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointer... just cleaned that up with a variable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Repaired tabs in makefile 🙄; added variable set in script.

9adbee6

Reviewers

mhagger

mhagger left review comments

Copilot code review Copilot

Copilot review effort

Applies to this pull request for everyone.Learn more about Copilot code review.

Copilot left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.