GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — Handle very long lines in `git rev-list --objects` output by simonkundrik · Pull Request #158 · github/git-sizer ConversationProblem
on repositories that contain an object with a very long path name (the reporter of #157 saw a FixReplace The TestsAdded
Note on the 64 MiB cap
Closes #157
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThe `copy-oids` stage used `pipe.LinewiseFunction`, whose scanner rejects any line longer than 64 KiB with "bufio.Scanner: token too long". A single line of `git rev-list --objects` output can exceed that limit when an object has a very long path name, which aborts the whole object walk. Use `pipe.ScannerFunction` with a scanner that uses the same LF line-splitting but whose buffer starts at the usual 64 KiB and may grow up to 64 MiB, so normal usage stays cheap while pathologically long lines can still be processed. Closes github#157
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. git-sizer can fail on some very long linesUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |