GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Config prod fixes and better logging by GrantBirki · Pull Request #70 · github/hooks

Conversation

@GrantBirki

@GrantBirki GrantBirki commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
GrantBirki added 2 commits June 26, 2025 14:34
@GrantBirki
bump version
59bdcd1
@GrantBirki
fix: update production mode handling and logging in configuration
dd0f87d
Copilot AI review requested due to automatic review settings June 26, 2025 21:52
Copilot AI reviewed Jun 26, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the production mode configuration and improves logging by:

  • Removing the explicit production flag in favor of relying solely on the environment value.
  • Adding debug logging for the global configuration in the builder component.
  • Bumping the version and updating corresponding tests to reflect these changes.

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
spec/unit/lib/hooks/core/config_loader_spec.rb Removed tests for the production flag in favor of environment check
spec/unit/lib/hooks/core/builder_spec.rb Updated custom logger expectations with added debug methods
lib/hooks/version.rb Bumped version from 0.6.2 to 0.6.3
lib/hooks/core/config_loader.rb Removed production flag assignment based on environment
lib/hooks/core/builder.rb Added debug logging for global config and removed production log
lib/hooks/app/endpoints/catchall.rb Updated error response enrichment to use @production instead
lib/hooks/app/api.rb Sets @production based on the environment
Comments suppressed due to low confidence (1)

lib/hooks/app/endpoints/catchall.rb:106

  • The change from using config[:production] to @production in the catchall endpoint may introduce unintended behavior if @production is not initialized in this scope. Consider explicitly passing the production flag to the endpoint or ensuring the instance variable is reliably set.
              error_response[:backtrace] = e.backtrace.join("\n") unless @production

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@GrantBirki
GrantBirki merged commit 1e806ce into main Jun 26, 2025
@GrantBirki
GrantBirki deleted the config-prod-fixes branch June 26, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@GrantBirki
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.