GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Decide on pending cops by issyl0 · Pull Request #484 · github/rubocop-github

Conversation

@issyl0

@issyl0 issyl0 commented Oct 2, 2026

Copy link
Copy Markdown
Member

  • I bumped a consumer of this gem to its latest version and it produced a bunch of offenses.

  • Turns out that, per the README, as part of bumping the RuboCop version I should have categorized and promoted the new rules, otherwise, all are enabled by default because the pending cops aren't inherited.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
issyl0 and others added 2 commits October 2, 2026 09:39
@issyl0
Decide on pending default RuboCop rules
8d47341 
- Promote all pending cops into the default configuration based on their
  results against github/github and the Ruby styleguide.

Co-authored-by: Copilot <[email protected]>
@issyl0
Decide on pending Rails RuboCop rules
1bdf70d 
- Promote all Rails-specific pending cops into the Rails configuration
  based on their results against github/github.

Co-authored-by: Copilot <[email protected]>
Copilot AI balanced review requested due to automatic review settings October 2, 2026 09:11
@issyl0
issyl0 requested a review from a team as a code owner October 2, 2026 09:11
Copilot started reviewing on behalf of issyl0 October 2, 2026 09:11
View session
Copilot AI reviewed Oct 2, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

All pending cops receive explicit decisions, and the related cleanup is consistent and complete.

Review effort: Balanced
Findings: None

What changed in this PR

Promotes pending RuboCop rules into explicit configurations, preventing unexpected defaults for consumers.

Changes:

  • Explicitly enables or disables pending Ruby, performance, and Rails cops.
  • Clears both pending-cop files.
  • Removes an obsolete inline cop suppression.
File Description
config/​default.yml Records decisions for general cops.
config/​default_pending.yml Removes resolved pending cops.
config/​rails.yml Records decisions for Rails cops.
config/​rails_pending.yml Removes resolved pending cops.
lib/​rubocop/​cop/​github/​rails_view_render_literal.rb Removes obsolete suppression directives.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@issyl0
issyl0 enabled auto-merge October 2, 2026 09:32
@issyl0
Bump gem version to 0.29.0
e581980
@issyl0
issyl0 force-pushed the decide-on-pending-cops branch from 136b479 to e581980 Compare October 2, 2026 09:46
mclark
mclark approved these changes Oct 2, 2026
View reviewed changes
@issyl0
issyl0 merged commit 205099c into main Oct 2, 2026
10 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@issyl0
issyl0 deleted the decide-on-pending-cops branch October 2, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mclark mclark mclark approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@issyl0 @mclark
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.