GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add ability to add collaborator by mtscout6 · Pull Request #462 · github-tools/github

Conversation

@mtscout6

@mtscout6 mtscout6 commented Jul 16, 2017

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jiaqingweek reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
mtscout6 added 5 commits July 16, 2017 12:02
@mtscout6
Add ability to add collaborator
6e0b9de
@mtscout6
Fix ESLint to work with async/await
d3a4373
@mtscout6
Update supported Node Versions
03914f2
@mtscout6
Cleanup page requests to use async / await
4fca61d
@mtscout6
Convert rateLimit test to async / await
699d092
@mtscout6
mtscout6 force-pushed the addCollaborator branch from f0642ce to 699d092 Compare July 16, 2017 23:54
@mtscout6
Fix failing test
c5c3060
@codecov-io

codecov-io commented Jul 17, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@22b889c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #462   +/-   ##
=========================================
  Coverage          ?   91.11%           
=========================================
  Files             ?       12           
  Lines             ?      405           
  Branches          ?        0           
=========================================
  Hits              ?      369           
  Misses            ?       36           
  Partials          ?        0
Impacted Files Coverage Δ
lib/Team.js 100% <ø> (ø)
lib/Requestable.js 94.17% <100%> (ø)
lib/Repository.js 80.83% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22b889c...c5c3060. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mtscout6 mtscout6 mentioned this pull request Jul 17, 2017
There is no create/add Collaborator #457
Open
MarkHerhold
MarkHerhold reviewed Aug 5, 2017
View reviewed changes
Comment thread .travis.yml
sudo: false
language: node_js
node_js:
- '8'

@MarkHerhold MarkHerhold Aug 5, 2017

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I opened PR #468 to to test against Node.js v8, which can be closed if this is merged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@j-rewerts

j-rewerts commented Apr 7, 2019

Copy link
Copy Markdown
Member

It seems like this API was considered preview? Newer docs have the URL being /repos/:owner/:repo/collaborators/:username, which is the same as the one that was used, so that's nice!

This PR would be easier to review if it didn't also switch the CI and add async await. @clayreimann Is there any plans to change which versions of Node this library builds for? I'm thinking we could merge in the addCollaborator stuff and leave async await for another day.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@adjetey0

adjetey0 commented Apr 22, 2026

Copy link
Copy Markdown

This branch has conflicts that must be resolved
Changes can be cleanly merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@MarkHerhold MarkHerhold MarkHerhold left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mtscout6 @codecov-io @j-rewerts @adjetey0 @MarkHerhold
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.