GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable to pass an object to createBlob by dudaerich · Pull Request #464 · github-tools/github

Conversation

@dudaerich

@dudaerich dudaerich commented Jul 27, 2017

Copy link
Copy Markdown

createBlob automatically encodes string parameter
by Utf8 library. In some cases the string value
can be already encoded in Utf8 so the encoding
should be skipped.

This commit enables to pass object containing
the content and encoding items. This object is
directly sent to Github. Users have better control
about what is actually sending.

closes #463

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dudaerich
dudaerich force-pushed the issue-463 branch from b34e192 to 761149c Compare July 27, 2017 17:13
@j-rewerts

j-rewerts commented Apr 7, 2019

Copy link
Copy Markdown
Member

This definitely seems like an important issue. @dudaerich Would you be able to write a test that demonstrates the issue you've run into?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dudaerich

dudaerich commented Apr 8, 2019

Copy link
Copy Markdown
Author

@j-rewerts sure. You can find it in this commit.
j-rewerts reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@j-rewerts

j-rewerts commented Apr 9, 2019

Copy link
Copy Markdown
Member

Could you put that on your issue-463 branch?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dudaerich
Enable to pass an object to createBlob
24f9c28 
createBlob automatically encodes string parameter
by Utf8 library. In some cases the string value
can be already encoded in Utf8 so the encoding
should be skipped.

This commit enables to pass object containing
the content and encoding items. This object is
directly sent to Github. Users have better control
about what is actually sending.

closes github-tools#463
@dudaerich
dudaerich force-pushed the issue-463 branch from 761149c to 24f9c28 Compare April 9, 2019 18:40
@dudaerich

dudaerich commented Apr 9, 2019

Copy link
Copy Markdown
Author

Done. I updated the test to use the object type. Otherwise it would still fail.

To be honest, I am not very convinced that my fix is right. Its advantage is that is backward compatible. On the other hand it is quite unexpected that this test fails. IMO the library shouldn't encode strings to UTF-8. On most platforms UTF-8 is default encoding so it doesn't make sense to encode already encoded strings. If someone uses more exotic encoding, they can encode it to UTF-8 before they pass it to the library. Wdyt?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

createBlob automatically encodes string content to UTF8

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dudaerich @j-rewerts
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.