GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — WIP: Search paging by j-rewerts · Pull Request #596 · github-tools/github

Conversation

@j-rewerts

@j-rewerts j-rewerts commented Oct 24, 2019

Copy link
Copy Markdown
Member

Added optional manual paging of search. Closes #562.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
j-rewerts added 5 commits October 22, 2019 10:04
@j-rewerts
Added paged results to search tests.
3bda28a
@j-rewerts
Assert the exact response length of all search tests.
fb4cc02
@j-rewerts
Fixed error handling.
cd8c27f
@j-rewerts
Fixed duplicate params when paging.
5718843
@j-rewerts
Added single page search.
8b54caf
@j-rewerts

j-rewerts commented Oct 30, 2019

Copy link
Copy Markdown
Member Author

@DanielRuf I'm running into some issue with Nock I just can't seem to sort out. When I run the search tests on their own, my new test passes. If I run all tests using npm run test, my new test fails. Any idea why this may be happening?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@j-rewerts
j-rewerts requested a review from DanielRuf October 30, 2019 18:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanielRuf DanielRuf Awaiting requested review from DanielRuf

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

could it be pageable for searching

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@j-rewerts
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.