GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Encode reserved characters in content paths by Bolt4243 · Pull Request #809 · github-tools/github

Conversation

Bolt4243 commented Sep 9, 2026

Copy link

Copy Markdown

Content paths were encoded with encodeURI, which leaves # and ? untouched. That made names such as docs/release#notes.md and reports/draft?.txt look like URL fragments or query strings instead of complete file paths.

Encode each path segment separately so directory slashes remain intact, and use the same path handling for reads, writes, and deletes. The focused offline harness fails on the base commit and passes with this fix. I also added Mocha/Nock regression cases, but did not run the full integration suite.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Encode repository content paths

7335eb9

ghost approved these changes

Oct 12, 2026

View reviewed changes

This branch has not been deployed

No deployments

Reviewers

1 more reviewer

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.