GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Specify version for denoland/setup-deno by haphut · Pull Request #35 · githubocto/flat

This repository was archived by the owner on Aug 6, 2026. It is now read-only.

Conversation

@haphut

@haphut haphut commented May 30, 2021

Copy link
Copy Markdown

denoland/setup-deno@v1 was published recently and is used in the
README.md of the action:
https://github.com/denoland/setup-deno/blob/4a4e59637fa62bd6c086a216c7e4c5b457ea9e79/README.md

We should use it, too.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@haphut
Specify version for denoland/setup-deno
16d2634 
denoland/setup-deno@v1 was published recently and is used in the
README.md of the action:
https://github.com/denoland/setup-deno/blob/4a4e59637fa62bd6c086a216c7e4c5b457ea9e79/README.md

We should use it, too.
@irealva

irealva commented Jun 2, 2021

Copy link
Copy Markdown
Contributor

Note for team: we would have to update Deno versions in Flat Editor and demos if we merge this PR. And documentation.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@haphut

haphut commented Jun 2, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

Thanks for the response! I meant to make just a small improvement but I guess it's not that simple.

Currently the only difference between @main and @v1 seems to be the deno download URL. Do you mean that the team needs to update the setup-deno versions in Flat Editor and demos for consistency? EDIT: I assume you do: https://github.com/search?p=1&q=org%3Agithubocto+setup-deno&type=Code . That is a bit of work to fork all of those for a one-line change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@haphut @irealva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.