GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — add all JSON.stringify args to writeJSON function by adblanc · Pull Request #7 · githubocto/flat-postprocessing

This repository was archived by the owner on Aug 6, 2026. It is now read-only.

Conversation

@adblanc

@adblanc adblanc commented Jul 21, 2021

Copy link
Copy Markdown

Hello,

First of all, thanks for this whole project, I really enjoy it.
However, I found myself wanting to indent the json content of my file but couldn't using the writeJSON from the lib.
I guess this shouldn't add any regressions, please let me know what you think about this 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Adrien Blanc
add all JSON.stringify args to writeJSON function
92b789a
@irealva

irealva commented Jul 22, 2021

Copy link
Copy Markdown
Contributor

Thank you! This seems useful and your code works well.

My only request is would you be able to take a pass at the README?

We would have to at the least:

  • update the inputs for writeJSON
  • ideally, keep the usage example, just add an extra one that shows the additional parameters
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
irealva
irealva reviewed Jul 22, 2021
View reviewed changes
Comment thread tests/json-test.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Adrien Blanc
updated writeJSON README
f42f02e
@adblanc

adblanc commented Jul 23, 2021

Copy link
Copy Markdown
Author

Thanks for the review, I had completely forgot the README part ! 😄

I used any to type replacer in the README to simplify as it's an overload with either (this: any, key: string, value: any) => any or (number | string)[] | null
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@irealva

irealva commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@irealva
irealva merged commit 59569f9 into githubocto:main Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@irealva irealva irealva left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@adblanc @irealva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.