GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow to pass write options by cyberdelia · Pull Request #8 · githubocto/flat-postprocessing

This repository was archived by the owner on Aug 6, 2026. It is now read-only.

Conversation

@cyberdelia

@cyberdelia cyberdelia commented Aug 2, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Allow to pass write options when useful, which mostly allow to use the append mode.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
irealva and idan reacted with heart emoji
All reactions
  • ❤️ 2 reactions
@cyberdelia
Allow to pass write options
93d7830
@irealva

irealva commented Aug 3, 2021

Copy link
Copy Markdown
Contributor

Hi there, thanks for the PR! This works well. As you mentioned the append use case is really useful.

Would you mind adding a test for both CSV and TXT? The benefit of the test (beyond making it safer to expand this library) is that it also shows someone how to use this feature.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@idan
Add tests
74d7c5f
@idan
idan requested a review from irealva August 3, 2021 20:33
cyberdelia
cyberdelia commented Aug 3, 2021
View reviewed changes
Comment thread tests/csv-test.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@cyberdelia

cyberdelia commented Aug 3, 2021

Copy link
Copy Markdown
Contributor Author

@idan Thanks for beating me to it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@idan
Whitespace fix
2062087
@idan

idan commented Aug 3, 2021

Copy link
Copy Markdown
Contributor

Ah, also need to update the README
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@idan

idan commented Aug 3, 2021

Copy link
Copy Markdown
Contributor

Oh nevermind, I was looking at the README on main 🤦🏻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
idan
idan approved these changes Aug 3, 2021
View reviewed changes

@idan idan left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@idan

idan commented Aug 3, 2021

Copy link
Copy Markdown
Contributor

We should cut a release after merging this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@irealva
irealva merged commit 8e8bdec into githubocto:main Aug 4, 2021
@cyberdelia
cyberdelia deleted the optionally-optional branch August 4, 2021 15:46
@cyberdelia

cyberdelia commented Aug 4, 2021

Copy link
Copy Markdown
Contributor Author

🕺🏻 💃🏻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@irealva irealva Awaiting requested review from irealva
1 more reviewer
@idan idan idan approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@cyberdelia @irealva @idan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.