GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Merge pull request #1971 from fvalette-ledger/fix-fetch-progress-bar · gitpython-developers/GitPython@a527224

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • .github/workflows
    • pythonpackage.yml
  • git
    • cmd.py
    • remote.py
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎.github/workflows/pythonpackage.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/pythonpackage.yml
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
16+
os: ["ubuntu-22.04", "macos-latest", "windows-latest"]
1717
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
1818
exclude:
1919
- os: "macos-latest"
Collapse file

‎git/cmd.py‎

Copy file name to clipboardExpand all lines: git/cmd.py
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1269,6 +1269,7 @@ def execute(
12691269
stdout=stdout_sink,
12701270
shell=shell,
12711271
universal_newlines=universal_newlines,
1272+
encoding=defenc if universal_newlines else None,
12721273
**subprocess_kwargs,
12731274
)
12741275
except cmd_not_found_exception as err:
Collapse file

‎git/remote.py‎

Copy file name to clipboardExpand all lines: git/remote.py
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -894,7 +894,7 @@ def _get_fetch_info_from_stderr(
894894
None,
895895
progress_handler,
896896
finalizer=None,
897-
decode_streams=True,
897+
decode_streams=False,
898898
kill_after_timeout=kill_after_timeout,
899899
)
900900

@@ -1071,7 +1071,7 @@ def fetch(
10711071
Git.check_unsafe_options(options=list(kwargs.keys()), unsafe_options=self.unsafe_git_fetch_options)
10721072

10731073
proc = self.repo.git.fetch(
1074-
"--", self, *args, as_process=True, with_stdout=False, universal_newlines=False, v=verbose, **kwargs
1074+
"--", self, *args, as_process=True, with_stdout=False, universal_newlines=True, v=verbose, **kwargs
10751075
)
10761076
res = self._get_fetch_info_from_stderr(proc, progress, kill_after_timeout=kill_after_timeout)
10771077
if hasattr(self.repo.odb, "update_cache"):
@@ -1125,7 +1125,7 @@ def pull(
11251125
Git.check_unsafe_options(options=list(kwargs.keys()), unsafe_options=self.unsafe_git_pull_options)
11261126

11271127
proc = self.repo.git.pull(
1128-
"--", self, refspec, with_stdout=False, as_process=True, universal_newlines=False, v=True, **kwargs
1128+
"--", self, refspec, with_stdout=False, as_process=True, universal_newlines=True, v=True, **kwargs
11291129
)
11301130
res = self._get_fetch_info_from_stderr(proc, progress, kill_after_timeout=kill_after_timeout)
11311131
if hasattr(self.repo.odb, "update_cache"):

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.