GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — incorporate review feedback from @EliahKagan · gitpython-developers/GitPython@f3ab5d3

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • git
    • util.py
  • test
    • test_util.py
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎git/util.py‎

Copy file name to clipboardExpand all lines: git/util.py
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,8 @@ def is_cygwin_git(git_executable: PathLike) -> bool: ...
490490

491491

492492
def is_cygwin_git(git_executable: Union[None, PathLike]) -> bool:
493-
_logger.debug(f"sys.platform = {sys.platform}, git_executable = {git_executable}")
493+
# TODO: when py3.7 support is dropped, use the new interpolation f"{variable=}"
494+
_logger.debug(f"sys.platform={sys.platform!r}, git_executable={git_executable!r}")
494495
if sys.platform != "cygwin":
495496
return False
496497
elif git_executable is None:
Collapse file

‎test/test_util.py‎

Copy file name to clipboardExpand all lines: test/test_util.py
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -354,6 +354,7 @@ class TestIsCygwinGit:
354354
"""Tests for :func:`is_cygwin_git`"""
355355

356356
def test_on_path_executable(self):
357+
# Currently we assume tests run on Cygwin use Cygwin git. See #533 and #1455 for background.
357358
if sys.platform == "cygwin":
358359
assert is_cygwin_git("git")
359360
else:

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.